From: aleksi.aalto@iki.fi
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2010, #01; Sat, 4)
Date: Mon, 6 Dec 2010 02:54:27 +0200 (EET) [thread overview]
Message-ID: <alpine.SOC.2.00.1012060235180.18993@kekkonen.cs.hut.fi> (raw)
In-Reply-To: <7v8w04vvvr.fsf@alter.siamese.dyndns.org>
On Sun, 5 Dec 2010, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
>> On Sat, Dec 04, 2010 at 10:30:21PM -0800, Junio C Hamano wrote:
>>
>>> * aa/status-hilite-branch (2010-11-18) 1 commit
>>> - status: show branchname with a configurable color
>>>
>>> I am indifferent/uninterested; I don't see anything wrong with it, but I
>>> do not find coloring the field particularly useful myself.
>>
>> I am not particularly interested, either, but FWIW, the gitcommit syntax
>> highlighting that ships with vim does highlight this, so there are at
>> least other people who think this is a good idea.
>
> As you already know, when I say "'Meh' personally", I am not saying "I
> want to forbid others to want it".
>
> How does vim highlight the other parts of that particular line? Does it
> keep them intact, or paint them in some other color?
The default colorscheme results in the branchname being colored with a
different color than the rest of the header. Also the texts "Changes to be
committed:" and "Untracked files" are colored with the same color. However
with some other colorschemes, these texts have a different color from the
branchname.
> I had this suspicion that the class of people who choose a non default
> status.header color and the class of people who choose plain there (or
> have been happy with the default) expect different things. The former
> prefer louder output, different pieces of information painted in different
> colors to help them chromatically distinguish them. The latter (including
> myself) favor subdued output, without too many colors distacting them
> while reading the output.
>
> This suspicion further led me to think that the former would want this new
> feature to paint the branch name in a color different from status.header
> color, while the latter would want it in plain. So the default of "plain"
> would be a win for both audiences.
This reasoning sounds good to me.
:Aga
next prev parent reply other threads:[~2010-12-06 0:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 6:30 What's cooking in git.git (Dec 2010, #01; Sat, 4) Junio C Hamano
2010-12-05 7:39 ` Jeff King
2010-12-05 19:54 ` Junio C Hamano
2010-12-06 0:54 ` aleksi.aalto [this message]
2010-12-09 17:27 ` Jeff King
2010-12-10 19:55 ` Junio C Hamano
2010-12-05 10:13 ` Yann Dirson
2010-12-05 20:23 ` Junio C Hamano
2010-12-06 7:29 ` Yann Dirson
2010-12-06 8:13 ` Miles Bader
2010-12-06 8:21 ` Yann Dirson
2010-12-06 8:39 ` Miles Bader
2010-12-06 8:48 ` Yann Dirson
2010-12-06 9:13 ` Miles Bader
2010-12-06 11:31 ` Yann Dirson
2010-12-06 11:37 ` Matthieu Moy
2010-12-10 21:59 ` Junio C Hamano
2010-12-05 12:36 ` aleksi.aalto
2010-12-05 15:51 ` Patrick Rouleau
2010-12-05 13:00 ` Erik Faye-Lund
2010-12-05 20:15 ` Junio C Hamano
2010-12-05 15:00 ` Michael J Gruber
2010-12-05 20:06 ` Junio C Hamano
2010-12-06 8:55 ` Michael J Gruber
2010-12-06 15:39 ` Thiago Farina
2010-12-08 11:23 ` t9010 broken in pu [Re: What's cooking in git.git (Dec 2010, #01; Sat, 4)] Thomas Rast
2010-12-08 11:28 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.2.00.1012060235180.18993@kekkonen.cs.hut.fi \
--to=aleksi.aalto@iki.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).