From: Daniel Barkalow <barkalow@iabervon.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/8] Add a lockfile function to append to a file
Date: Sun, 20 Apr 2008 15:43:23 -0400 (EDT) [thread overview]
Message-ID: <alpine.LNX.1.00.0804201528350.19665@iabervon.org> (raw)
In-Reply-To: <7vtzhxce9g.fsf@gitster.siamese.dyndns.org>
On Sat, 19 Apr 2008, Junio C Hamano wrote:
> Daniel Barkalow <barkalow@iabervon.org> writes:
>
> > This takes care of copying the original contents into the replacement
> > file after the lock is held, so that concurrent additions can't miss
> > each other's changes.
> >
> > Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> > ---
> > How about this? Also doesn't leak a fd and catches trying to append to a
> > file you can't read. Should I worry about mmap failing after the open?
>
> We have copy.c to copy small existing files, while detecting failure to
> copy properly. How about doing something like this instead?
Yeah, that's obviously the right thing to use.
-Daniel
*This .sig left intentionally blank*
next prev parent reply other threads:[~2008-04-20 19:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 0:02 [PATCH 2/8] Add a lockfile function to append to a file Daniel Barkalow
2008-04-20 4:59 ` Junio C Hamano
2008-04-20 16:14 ` Johannes Schindelin
2008-04-20 19:43 ` Daniel Barkalow [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-17 23:32 Daniel Barkalow
2008-04-17 23:41 ` Junio C Hamano
2008-04-17 23:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.1.00.0804201528350.19665@iabervon.org \
--to=barkalow@iabervon.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).