From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/8] Add a lockfile function to append to a file
Date: Thu, 17 Apr 2008 16:51:39 -0700 [thread overview]
Message-ID: <7vy77ckpkk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0804171931480.19665@iabervon.org> (Daniel Barkalow's message of "Thu, 17 Apr 2008 19:32:26 -0400 (EDT)")
Daniel Barkalow <barkalow@iabervon.org> writes:
> +int hold_lock_file_for_append(struct lock_file *lk, const char *path, int die_on_error)
> +{
> + int fd = lock_file(lk, path);
> + struct stat st;
> + if (!stat(path, &st)) {
> + int orig_fd = open(path, O_RDONLY);
> + size_t mmap_size = xsize_t(st.st_size);
> + void *mmap = xmmap(NULL, mmap_size, PROT_READ, MAP_PRIVATE,
> + orig_fd, 0);
> + write_or_die(fd, mmap, mmap_size);
> + munmap(mmap, mmap_size);
> + }
> + if (fd < 0 && die_on_error)
> + die("unable to create '%s.lock': %s", path, strerror(errno));
> + return fd;
> +}
Another glitch. What should we do when stat(path) fails but the file
cannot be read?
I think the sequence actually should be:
fd = lock_file();
if (fd < 0)
error out;
orig_fd = open(path, O_RDONLY);
if (orig_fd < 0) {
if (errno != ENOENT)
die("unable to open %s", path);
copy;
}
return fd;
next prev parent reply other threads:[~2008-04-17 23:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 23:32 [PATCH 2/8] Add a lockfile function to append to a file Daniel Barkalow
2008-04-17 23:41 ` Junio C Hamano
2008-04-17 23:51 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-18 0:02 Daniel Barkalow
2008-04-20 4:59 ` Junio C Hamano
2008-04-20 16:14 ` Johannes Schindelin
2008-04-20 19:43 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy77ckpkk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).