From: Thomas Gleixner <tglx@linutronix.de>
To: Jeff King <peff@peff.net>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Chris Metcalf <cmetcalf@tilera.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE
Date: Tue, 23 Oct 2012 23:25:06 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1210232307480.2756@ionos> (raw)
In-Reply-To: <20121023205119.GA27729@sigill.intra.peff.net>
On Tue, 23 Oct 2012, Jeff King wrote:
> On Tue, Oct 23, 2012 at 10:47:28PM +0200, Thomas Gleixner wrote:
>
> > I agree that this is a common issue. Acked-by/Reviewed-by mails come
> > in after the fact that the patch has been committed to an immutable
> > (i.e no-rebase mode) branch or if the change in question already hit
> > Linus tree.
> >
> > Still it would be nice to have a recording of that in the git tree
> > itself.
> >
> > Something like: "git --attach SHA1 <comment>" would be appreciated!
>
> It is spelled:
>
> git notes add -m <comment> SHA1
Cool!
> The resulting notes are stored in a separate revision-controlled branch
Which branch(es) is/are that ? What are the semantics of that?
Assume I commit something to branch "foo"
Now I get that late Ack/Reviewed-by and want to associate that to that
commit in branch "foo". Does that go into "notes/foo" ?
If yes, good. (Any other sensible prefix is good as well). If no,
where does it go to?
Later when I send a pull request to my upstream maintainer for branch
"foo" does he get "notes/foo" automagically or do I have to request to
pull him that separately?
Either way is fine for me, though something which lets me "automate"
that would be appreciated. I can work around that easily as my pull
requests are generated via scripts, so I can add the secondary one for
the dependent "notes" branch if necessary. Though it would be nice to
avoid that. Avoiding that, i.e having a straight connection (maybe
configurable) between "foo" and "notes/foo" and the commits which have
not yet hit my upstream maintainer would make my life easier. I.e. I
just have to check "foo" for stuff which is not upstream yet instead
of checking both, but that might just be my laziness.
Thoughts?
tglx
next prev parent reply other threads:[~2012-10-23 21:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121016223508.GR2616@ZenIV.linux.org.uk>
[not found] ` <201210192041.q9JKf7jD003998@farm-0010.internal.tilera.com>
[not found] ` <20121019213548.GR2616@ZenIV.linux.org.uk>
[not found] ` <5082A1F1.3080303@tilera.com>
[not found] ` <20121020153401.GT2616@ZenIV.linux.org.uk>
[not found] ` <20121020171643.GU2616@ZenIV.linux.org.uk>
[not found] ` <5086D432.4070008@tilera.com>
[not found] ` <20121023184122.GZ2616@ZenIV.linux.org.uk>
2012-10-23 20:47 ` [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE Thomas Gleixner
2012-10-23 20:51 ` Jeff King
2012-10-23 21:09 ` Catalin Marinas
2012-10-23 21:22 ` Jeff King
2012-10-24 11:18 ` Catalin Marinas
2012-10-23 21:25 ` Thomas Gleixner [this message]
2012-10-23 21:47 ` Jeff King
2012-10-23 22:06 ` Marc Gauthier
2012-10-23 22:23 ` Jeff King
2012-10-24 6:02 ` Johannes Sixt
2012-10-24 1:02 ` Linus Torvalds
2012-10-24 1:56 ` Al Viro
2012-10-24 2:14 ` Linus Torvalds
2012-10-24 6:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1210232307480.2756@ionos \
--to=tglx@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@tilera.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).