From: Thomas Gleixner <tglx@linutronix.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE
Date: Tue, 23 Oct 2012 22:47:28 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1210232232070.2756@ionos> (raw)
In-Reply-To: <20121023184122.GZ2616@ZenIV.linux.org.uk>
On Tue, 23 Oct 2012, Al Viro wrote:
> On Tue, Oct 23, 2012 at 01:30:26PM -0400, Chris Metcalf wrote:
>
> > I fetched the series from your arch-tile branch and built it, and it works
> > fine. It looks good from my inspection:
> >
> > Acked-by: Chris Metcalf <cmetcalf@tilera.com>
>
> Thanks; Acked-by applied, branch pushed and put into no-rebase mode.
>
> BTW, something like detached Acked-by objects might be a good idea - i.e.
> commit-like git object with amendment to commit message of a given ancestor.
> The situation when ACKs come only after the commit has been pushed is quite
> common. Linus, what do you think about usefulness of such thing? Ability
> to append ACKed-by/Tested-by of an earlier commit to a branch instead of
> git commit --amend + possibly some cherry-picks + force-push, that is.
I agree that this is a common issue. Acked-by/Reviewed-by mails come
in after the fact that the patch has been committed to an immutable
(i.e no-rebase mode) branch or if the change in question already hit
Linus tree.
Still it would be nice to have a recording of that in the git tree
itself.
Something like: "git --attach SHA1 <comment>" would be appreciated!
Thanks,
tglx
next parent reply other threads:[~2012-10-23 20:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121016223508.GR2616@ZenIV.linux.org.uk>
[not found] ` <201210192041.q9JKf7jD003998@farm-0010.internal.tilera.com>
[not found] ` <20121019213548.GR2616@ZenIV.linux.org.uk>
[not found] ` <5082A1F1.3080303@tilera.com>
[not found] ` <20121020153401.GT2616@ZenIV.linux.org.uk>
[not found] ` <20121020171643.GU2616@ZenIV.linux.org.uk>
[not found] ` <5086D432.4070008@tilera.com>
[not found] ` <20121023184122.GZ2616@ZenIV.linux.org.uk>
2012-10-23 20:47 ` Thomas Gleixner [this message]
2012-10-23 20:51 ` [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE Jeff King
2012-10-23 21:09 ` Catalin Marinas
2012-10-23 21:22 ` Jeff King
2012-10-24 11:18 ` Catalin Marinas
2012-10-23 21:25 ` Thomas Gleixner
2012-10-23 21:47 ` Jeff King
2012-10-23 22:06 ` Marc Gauthier
2012-10-23 22:23 ` Jeff King
2012-10-24 6:02 ` Johannes Sixt
2012-10-24 1:02 ` Linus Torvalds
2012-10-24 1:56 ` Al Viro
2012-10-24 2:14 ` Linus Torvalds
2012-10-24 6:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1210232232070.2756@ionos \
--to=tglx@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@tilera.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).