From: Nicolas Pitre <nico@cam.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Alfred M. Szmidt" <ams@gnu.org>, git@vger.kernel.org
Subject: Re: [PATCH] Cast things properly to handle >2G files.
Date: Sun, 14 Jun 2009 22:43:46 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0906142239120.16467@xanadu.home> (raw)
In-Reply-To: <alpine.DEB.1.00.0906142215560.26154@pacific.mpi-cbg.de>
On Sun, 14 Jun 2009, Johannes Schindelin wrote:
> Hi,
>
> Disclaimer: if you are offended by constructive criticism, or likely to
> answer with insults to the comments I offer, please stop reading this mail
> now (and please do not answer my mail, either). :-)
>
> Still with me? Good. Nice to meet you.
>
> Just for the record: responding to a patch is my strongest way of saying
> that I appreciate your work.
>
> On Sun, 14 Jun 2009, Alfred M. Szmidt wrote:
>
> > This small patch fixes things so that repack, fsck, and other things
> > work on >2GiB files. There are still some other problems (cloning
> > over ssh being one), but this makes it atleast possible to handle such
> > files.
> >
> > (not subscribed, please CC)
>
> This is almost perfect, but please add a Signed-off-by: line.
>
> Oh, and maybe add a test like t/t5705-clone-2gb.sh?
Creating test for files >= 2GB is kinda hard. It'll be really slow and
take a lot of disk space, and I doubt people will be happy about that.
Been there. That's the only reason why I created the --index-version
argument to pack-objects: to fake behavior for huge files by the test
suite.
Nicolas
next prev parent reply other threads:[~2009-06-15 2:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 20:03 [PATCH] Cast things properly to handle >2G files Alfred M. Szmidt
2009-06-14 20:17 ` Johannes Schindelin
2009-06-15 2:43 ` Nicolas Pitre [this message]
2009-06-15 3:39 ` Alfred M. Szmidt
2009-06-15 4:06 ` Junio C Hamano
2009-06-15 8:45 ` Johannes Schindelin
2009-06-15 4:25 ` Linus Torvalds
2009-06-17 22:27 ` Alfred M. Szmidt
2009-06-17 22:45 ` Linus Torvalds
2009-06-17 23:16 ` Junio C Hamano
2009-06-18 0:22 ` Fix big left-shifts of unsigned char Linus Torvalds
2009-06-18 8:12 ` Johannes Schindelin
2009-06-18 8:21 ` Junio C Hamano
2009-06-18 16:08 ` Linus Torvalds
2009-06-18 16:45 ` Johannes Schindelin
2009-06-18 17:15 ` Linus Torvalds
2009-06-18 17:28 ` Fix various sparse warnings in the git source code Linus Torvalds
2009-06-18 17:45 ` Matthieu Moy
2009-06-18 17:52 ` Linus Torvalds
2009-06-18 21:48 ` Linus Torvalds
2009-06-17 22:51 ` [PATCH] Cast things properly to handle >2G files Linus Torvalds
2009-06-17 22:27 ` Alfred M. Szmidt
2009-06-17 22:48 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0906142239120.16467@xanadu.home \
--to=nico@cam.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=ams@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).