Re: [PATCH] Cast things properly to handle >2G files.

git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed

From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: ams@gnu.org, git@vger.kernel.org
Subject: Re: [PATCH] Cast things properly to handle >2G files.
Date: Mon, 15 Jun 2009 10:45:37 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0906151043180.4245@intel-tinevez-2-302> (raw)
In-Reply-To: <7vmy8ap2cq.fsf@alter.siamese.dyndns.org>

Hi,

On Sun, 14 Jun 2009, Junio C Hamano wrote:

> "Alfred M. Szmidt" <ams@gnu.org> writes:
> 
> >    Oh, and maybe add a test like t/t5705-clone-2gb.sh?
> >
> > Thank you, that is a very good idea.
> 
> Nah, one blob that is over 2gb, deltified against something else?  
> That's a bit too much for a test script.

Why not?  It's not a difficult thing to come up with such a test.  And 
just like t5705, it can be hidden behind an "EXPENSIVE_TEST=YesPlease" 
environment variable.  Maybe I should have spelt that out loud instead of 
relying on interested parties to know t5705.

And just like t5705 it should help people to verify that the patch solves 
the problems indeed.

Ciao,
Dscho

next prev parent reply	other threads:[~2009-06-15  8:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-14 20:03 [PATCH] Cast things properly to handle >2G files Alfred M. Szmidt
2009-06-14 20:17 ` Johannes Schindelin
2009-06-15  2:43   ` Nicolas Pitre
2009-06-15  3:39   ` Alfred M. Szmidt
2009-06-15  4:06     ` Junio C Hamano
2009-06-15  8:45       ` Johannes Schindelin [this message]
2009-06-15  4:25     ` Linus Torvalds
2009-06-17 22:27       ` Alfred M. Szmidt
2009-06-17 22:48         ` Linus Torvalds
2009-06-17 22:27       ` Alfred M. Szmidt
2009-06-17 22:45         ` Linus Torvalds
2009-06-17 23:16           ` Junio C Hamano
2009-06-18  0:22           ` Fix big left-shifts of unsigned char Linus Torvalds
2009-06-18  8:12             ` Johannes Schindelin
2009-06-18  8:21               ` Junio C Hamano
2009-06-18 16:08               ` Linus Torvalds
2009-06-18 16:45                 ` Johannes Schindelin
2009-06-18 17:15                   ` Linus Torvalds
2009-06-18 17:28                     ` Fix various sparse warnings in the git source code Linus Torvalds
2009-06-18 17:45                       ` Matthieu Moy
2009-06-18 17:52                         ` Linus Torvalds
2009-06-18 21:48                       ` Linus Torvalds
2009-06-17 22:51         ` [PATCH] Cast things properly to handle >2G files Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0906151043180.4245@intel-tinevez-2-302 \
    --to=johannes.schindelin@gmx.de \
    --cc=ams@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).