mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <>
To: "Łukasz Stelmach" <>
Cc:, Stefan Beller <>,
	Pat Thoyts <>
Subject: Re: [PATCH] git-gui: Prevent double UTF-8 conversion
Date: Tue, 28 Nov 2017 15:35:21 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]

Hi Łukasz,

On Tue, 28 Nov 2017, Łukasz Stelmach wrote:

> Set encoding to utf-8 for file descriptors used to receive data from git
> commands.

The patch only changes it for the `cat-file` command used to read the
latest commit message for amending.

Maybe the commit message should be adjusted to reflect as much?

> With encoding on the file descriptor set to "binary" Tcl (8.6 in my
> case) does double conversion which breaks e.g. author name in amended
> commits.

Is the problem in question occurring when a commit message contains
non-ASCII characters encoded in UTF-8 and you click the "Amend Last
Commit" radio button on the right side above the "Commit Message" text

I tested this with Tcl/Tk 8.6.7-1 of Git for Windows' SDK, and with Tcl/Tk
8.6.0+9 of Ubuntu 16.04.3 LTS, in both cases the encoding of a commit
message 'äöü' was handled correctly with "binary"...

Could you give more details about your system so it is easier for me to
understand where the difference comes from?

Having said that, I also tested it *with* your patch, and it does not
break anything.

> So, this is the second attempt to draw some attention to this patch,
> since the first one has somewhat failed.

Yeah, sadly Pat (who is still listed as the active Git GUI maintainer) has
fallen very, very silent for over a year.

Pinging about the status of the patch was definitely the right thing to


  reply	other threads:[~2017-11-28 14:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2017-11-28 10:21 ` [PATCH] git-gui: Prevent double UTF-8 conversion Łukasz Stelmach
2017-11-28 14:35   ` Johannes Schindelin [this message]
2017-12-02 10:33     ` Łukasz Stelmach
2017-12-02 12:20   ` [PATCH v2] " Łukasz Stelmach
2017-12-04 14:31     ` Johannes Schindelin
     [not found]     ` <>
2017-12-05 14:23       ` [PATCH v3] " Łukasz Stelmach
2017-12-07  0:06         ` Johannes Schindelin
     [not found]         ` <>
2017-12-14  9:32           ` [PATCH v4] " Łukasz Stelmach
2017-12-14  9:42             ` Eric Sunshine
     [not found]               ` <>
2017-12-14 10:43                 ` Łukasz Stelmach
2017-12-14 18:18                   ` Eric Sunshine
     [not found] <>
2017-08-21 11:53 ` [PATCH] " Łukasz Stelmach
2017-08-21 18:52   ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB. \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).