From: Eric Sunshine <sunshine@sunshineco.com>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
Pat Thoyts <patthoyts@users.sourceforge.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v4] git-gui: Prevent double UTF-8 conversion
Date: Thu, 14 Dec 2017 04:42:22 -0500 [thread overview]
Message-ID: <CAPig+cTYYGRynG8r_2DR53u77eCFDGe1BEDcEK3_cJQxT3yncQ@mail.gmail.com> (raw)
In-Reply-To: <20171214093257.15826-1-l.stelmach@samsung.com>
On Thu, Dec 14, 2017 at 4:32 AM, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
> Convert author's name and e-mail address from the UTF-8 (or any other)
> encoding in load_last_commit function the same way commit message is
> converted.
>
> Amending commits in git-gui without such conversion breaks UTF-8
> strings. For example, "\305\201ukasz" (as written by git cat-file) becomes
> "\303\205\302\201ukasz" in an amended commit.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> Reviewed-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
> Changes since v3:
>
> - Added Reviewed-by footer. Thank you Johannes Schindelin, for review.
No need to re-send. If you consult Junio's latest "What's cooking"[1],
you'll find that your patch has already graduated from his 'pu' branch
to 'next' and is slated to graduate to 'master' (at some point).
[1]: https://public-inbox.org/git/xmqqzi6mutcc.fsf@gitster.mtv.corp.google.com/
next prev parent reply other threads:[~2017-12-14 9:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171128102138eucas1p116ae54d723bb100202fae2c1aaf5a9d8@eucas1p1.samsung.com>
2017-11-28 10:21 ` [PATCH] git-gui: Prevent double UTF-8 conversion Łukasz Stelmach
2017-11-28 14:35 ` Johannes Schindelin
2017-12-02 10:33 ` Łukasz Stelmach
2017-12-02 12:20 ` [PATCH v2] " Łukasz Stelmach
2017-12-04 14:31 ` Johannes Schindelin
[not found] ` <CGME20171205142341eucas1p2b30072c799c8787f1b66db2fd4bac1a2@eucas1p2.samsung.com>
2017-12-05 14:23 ` [PATCH v3] " Łukasz Stelmach
2017-12-07 0:06 ` Johannes Schindelin
[not found] ` <CGME20171214093300eucas1p28ed9bf0261a43a12978b6a3bfe908321@eucas1p2.samsung.com>
2017-12-14 9:32 ` [PATCH v4] " Łukasz Stelmach
2017-12-14 9:42 ` Eric Sunshine [this message]
[not found] ` <CGME20171214104348eucas1p2921cdc8df00c90055927ec99eba3040a@eucas1p2.samsung.com>
2017-12-14 10:43 ` Łukasz Stelmach
2017-12-14 18:18 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTYYGRynG8r_2DR53u77eCFDGe1BEDcEK3_cJQxT3yncQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.stelmach@samsung.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).