From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: David Turner <David.Turner@twosigma.com>
Cc: Jeff King <peff@peff.net>, "git@vger.kernel.org" <git@vger.kernel.org>
Subject: RE: [PATCH] Increase core.packedGitLimit
Date: Fri, 21 Apr 2017 11:34:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1704211131310.3480@virtualbox> (raw)
In-Reply-To: <4c111acb3f134aa9aef8648d75bd741f@exmbdft7.ad.twosigma.com>
Hi Dave,
On Thu, 20 Apr 2017, David Turner wrote:
>
> We might want to think about replacing git_config_ulong with
> git_config_size_t in nearly all cases. "long" has ceased to be
> useful. More modern versions of C prefer uint64_t, but I
> think that we'll usually want size_t because these values will
> be used as memory limits of various sorts.
Indeed, `unsigned long` has ceased to be useful ever since the
introduction of inttypes.h. It is just too undefined.
We probably also need git_config_off_t(), though, and maybe even
git_config_ssize_t().
I would definitely welcome a change in direction where we use datatypes
also as a documentation of the variables' purpose.
Ciao,
Dscho
next prev parent reply other threads:[~2017-04-21 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 20:41 [PATCH] Increase core.packedGitLimit David Turner
2017-04-20 21:02 ` Jeff King
2017-04-20 21:58 ` Johannes Schindelin
2017-04-20 22:04 ` David Turner
2017-04-21 9:34 ` Johannes Schindelin [this message]
2017-06-21 13:51 ` [PATCH] docs: update 64-bit core.packedGitLimit default Jeff King
2017-06-21 16:25 ` Stefan Beller
2017-06-21 18:06 ` Jeff King
2017-06-21 18:38 ` Junio C Hamano
2017-06-21 18:53 ` Jeff King
2017-06-21 19:22 ` Junio C Hamano
2017-06-21 19:31 ` Jeff King
2017-06-21 13:44 ` [PATCH] Increase core.packedGitLimit Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704211131310.3480@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=David.Turner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).