From: Jeff King <peff@peff.net>
To: David Turner <dturner@twosigma.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Increase core.packedGitLimit
Date: Thu, 20 Apr 2017 17:02:55 -0400 [thread overview]
Message-ID: <20170420210254.f4ykyi46bso5uj3o@sigill.intra.peff.net> (raw)
In-Reply-To: <20170420204118.17856-1-dturner@twosigma.com>
On Thu, Apr 20, 2017 at 04:41:18PM -0400, David Turner wrote:
> When core.packedGitLimit is exceeded, git will close packs. If there
> is a repack operation going on in parallel with a fetch, the fetch
> might open a pack, and then be forced to close it due to
> packedGitLimit being hit. The repack could then delete the pack
> out from under the fetch, causing the fetch to fail.
>
> Increase core.packedGitLimit's default value to prevent
> this.
>
> On current 64-bit x86_64 machines, 48 bits of address space are
> available. It appears that 64-bit ARM machines have no standard
> amount of address space (that is, it varies by manufacturer), and IA64
> and POWER machines have the full 64 bits. So 48 bits is the only
> limit that we can reasonably care about. We reserve a few bits of the
> 48-bit address space for the kernel's use (this is not strictly
> necessary, but it's better to be safe), and use up to the remaining
> 45. No git repository will be anywhere near this large any time soon,
> so this should prevent the failure.
Yep, I think this is a reasonable direction.
> ---
> git-compat-util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This probably needs an update to the core.packedGitLimit section of
Documentation/config.txt.
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 8a4a3f85e7..1c5de153a5 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -616,7 +616,7 @@ extern int git_lstat(const char *, struct stat *);
> #endif
>
> #define DEFAULT_PACKED_GIT_LIMIT \
> - ((1024L * 1024L) * (size_t)(sizeof(void*) >= 8 ? 8192 : 256))
> + ((1024L * 1024L) * (size_t)(sizeof(void*) >= 8 ? (32 * 1024L * 1024L) : 256))
I wondered if we would run afoul of integer sizes on 64-bit systems where
"long" is still only 32-bits (i.e., Windows). But I think it's OK,
because the values before we cast to size_t are in megabytes. So your
32*1024*1024 needs only 25 bits to store it. And then after we cast to
size_t, everything is in 64-bit.
-Peff
next prev parent reply other threads:[~2017-04-20 21:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 20:41 [PATCH] Increase core.packedGitLimit David Turner
2017-04-20 21:02 ` Jeff King [this message]
2017-04-20 21:58 ` Johannes Schindelin
2017-04-20 22:04 ` David Turner
2017-04-21 9:34 ` Johannes Schindelin
2017-06-21 13:51 ` [PATCH] docs: update 64-bit core.packedGitLimit default Jeff King
2017-06-21 16:25 ` Stefan Beller
2017-06-21 18:06 ` Jeff King
2017-06-21 18:38 ` Junio C Hamano
2017-06-21 18:53 ` Jeff King
2017-06-21 19:22 ` Junio C Hamano
2017-06-21 19:31 ` Jeff King
2017-06-21 13:44 ` [PATCH] Increase core.packedGitLimit Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420210254.f4ykyi46bso5uj3o@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).