From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Unbreak interactive GPG prompt upon signing
Date: Tue, 6 Sep 2016 18:39:06 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609061834490.129229@virtualbox> (raw)
In-Reply-To: <ced7502d-0095-bd90-19e3-c14d0e4d4f07@drmicha.warpmail.net>
Hi Michael,
On Tue, 6 Sep 2016, Michael J Gruber wrote:
> Johannes Schindelin venit, vidit, dixit 06.09.2016 10:01:
> > With the recent update in efee955 (gpg-interface: check gpg signature
> > creation status, 2016-06-17), we ask GPG to send all status updates to
> > stderr, and then catch the stderr in an strbuf.
> >
> > But GPG might fail, and send error messages to stderr. And we simply
> > do not show them to the user.
> >
> > Even worse: this swallows any interactive prompt for a passphrase. And
> > detaches stderr from the tty so that the passphrase cannot be read.
> >
> > So while the first problem could be fixed (by printing the captured
> > stderr upon error), the second problem cannot be easily fixed, and
> > presents a major regression.
>
> My Git has that commit and does ask me for the passphrase on the tty.
> Also, I do get error messages:
>
> git tag -u pebcak -s testt -m m
> error: gpg failed to sign the data
> error: unable to sign the tag
That is not GPG's error message. It just leaves users puzzled, is what it
does.
> which we could (maybe should) amend by gpg's stderr.
Right. But then we still do not solve the problem. The problem being that
some platforms cannot use getpass(prompt): it simply does not exist.
On Windows, we do not even have a /dev/tty (technically, GPG, being an
MSYS2 program, knows about /dev/tty, but we spawn it from a non-MSYS2
program, so there is a disconnect).
> > So let's just revert commit efee9553a4f97b2ecd8f49be19606dd4cf7d9c28.
>
> That "just" reintroduces the problem that the orignal patch solves.
Right. Which is: when some user misconfigures gpg, causing Git to run
something different that simply succeeds, there is no signature.
This is a minor issue, as it requires a user to configure gpg, and do a
bad job at it.
Not being able to input the passphrase on Windows is a major issue, as the
user has done nothing wrong.
> The passphrase/tty issue must be Windows specific - or the non-issue
> Linux-specific, if you prefer.
Sure. Let's talk about semantics. Oh wait, maybe we should work on
resolving the issue instead.
> > This fixes https://github.com/git-for-windows/git/issues/871
To reiterate: this is the problem I need to see solved.
Ciao,
Dscho
prev parent reply other threads:[~2016-09-06 16:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 8:01 [PATCH] Unbreak interactive GPG prompt upon signing Johannes Schindelin
2016-09-06 12:32 ` Michael J Gruber
2016-09-06 13:13 ` [PATCH] gpg-interface: reflect stderr to stderr Michael J Gruber
2016-09-06 16:30 ` Johannes Schindelin
2016-09-06 16:42 ` Johannes Schindelin
2016-09-06 16:43 ` Johannes Schindelin
2016-09-07 8:27 ` Michael J Gruber
2016-09-07 8:39 ` Jeff King
2016-09-07 9:32 ` Michael J Gruber
2016-09-08 18:20 ` Junio C Hamano
2016-09-08 20:03 ` Jeff King
2016-09-08 21:36 ` Junio C Hamano
2016-09-12 13:39 ` Michael J Gruber
2018-10-02 13:02 ` Johannes Schindelin
2016-09-09 7:28 ` Johannes Schindelin
2016-09-06 16:39 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609061834490.129229@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).