From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] gpg-interface: reflect stderr to stderr
Date: Tue, 6 Sep 2016 18:30:16 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609061827290.129229@virtualbox> (raw)
In-Reply-To: <18a7e2984121d988137c135ec560fee56506981b.1473167263.git.git@drmicha.warpmail.net>
Hi Michael,
On Tue, 6 Sep 2016, Michael J Gruber wrote:
> efee955 ("gpg-interface: check gpg signature creation status",
> 2016-06-17) used stderr to capture gpg's status output, which is the
> only reliable way for status checks. As a side effect, stderr was not
> shown to the user any more.
>
> In case of a gpg error, reflect the whole captured buffer to stderr.
>
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
> A full blown approach would use --status-fd=4 or such rather than hijacking stderr.
> This would require an extension of pipe_command() etc. to handle yet another fd.
As I indicated in my patch, this is not enough on Windows. In fact, my
first version of a patch tried to do exactly what you presented here, and
all it did was make the error message a bit more verbose:
-- snip --
error: gpg failed to sign the data:
[GNUPG:] USERID_HINT <key> Johannes Schindelin <johannes.schindelin@gmx.de>
[GNUPG:] NEED_PASSPHRASE <key> <key2> 1 0
gpg: cannot open tty `no tty': No such file or directory
error: unable to sign the tag
-- snap --
This is not a fix for the issue reported on the Git for Windows, but only
half a fix.
Ciao,
Dscho
next prev parent reply other threads:[~2016-09-06 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 8:01 [PATCH] Unbreak interactive GPG prompt upon signing Johannes Schindelin
2016-09-06 12:32 ` Michael J Gruber
2016-09-06 13:13 ` [PATCH] gpg-interface: reflect stderr to stderr Michael J Gruber
2016-09-06 16:30 ` Johannes Schindelin [this message]
2016-09-06 16:42 ` Johannes Schindelin
2016-09-06 16:43 ` Johannes Schindelin
2016-09-07 8:27 ` Michael J Gruber
2016-09-07 8:39 ` Jeff King
2016-09-07 9:32 ` Michael J Gruber
2016-09-08 18:20 ` Junio C Hamano
2016-09-08 20:03 ` Jeff King
2016-09-08 21:36 ` Junio C Hamano
2016-09-12 13:39 ` Michael J Gruber
2018-10-02 13:02 ` Johannes Schindelin
2016-09-09 7:28 ` Johannes Schindelin
2016-09-06 16:39 ` [PATCH] Unbreak interactive GPG prompt upon signing Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609061827290.129229@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).