git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <j6t@kdbg.org>
Cc: David Turner <dturner@twopensource.com>,
	git@vger.kernel.org, pclouds@gmail.com, aevarb@gmail.com,
	jeffhost@microsoft.com
Subject: Re: [PATCH v3 03/16] index-helper: new daemon for caching index and related stuff
Date: Thu, 7 Apr 2016 16:14:50 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1604071614250.2967@virtualbox> (raw)
In-Reply-To: <5705FC59.2050801@kdbg.org>

Hi,

On Thu, 7 Apr 2016, Johannes Sixt wrote:

> Am 07.04.2016 um 00:11 schrieb David Turner:
> > +static void share_index(struct index_state *istate, struct shm *is)
> > +{
> > +	void *new_mmap;
> > +	if (istate->mmap_size <= 20 ||
> > +	    hashcmp(istate->sha1,
> > +		    (unsigned char *)istate->mmap + istate->mmap_size - 20)
> > ||
> > +	    !hashcmp(istate->sha1, is->sha1) ||
> > +	    git_shm_map(O_CREAT | O_EXCL | O_RDWR, 0700, istate->mmap_size,
> > +			&new_mmap, PROT_READ | PROT_WRITE, MAP_SHARED,
> > +			"git-index-%s", sha1_to_hex(istate->sha1)) < 0)
> 
> Builds which have NO_MMAP set require that MAP_PRIVATE is set. So I would
> guess that at this point you leave those builds behind. Unless we declare
> such systems as hopelessly outdated and remove NO_MMAP and compat/mmap.c or
> you support index-helper only when NO_MMAP is not set.

I vote for the latter: support index-helper only when NO_MMAP is unset.

Ciao,
Dscho

  reply	other threads:[~2016-04-07 14:15 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 22:11 [PATCH v3 00/16] index-helper, watchman David Turner
2016-04-06 22:11 ` [PATCH v3 01/16] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-06 22:11 ` [PATCH v3 02/16] read-cache: allow to keep mmap'd memory after reading David Turner
2016-04-06 22:11 ` [PATCH v3 03/16] index-helper: new daemon for caching index and related stuff David Turner
2016-04-07  6:21   ` Johannes Sixt
2016-04-07 14:14     ` Johannes Schindelin [this message]
2016-04-07 18:47       ` David Turner
2016-04-08 14:17         ` Johannes Schindelin
2016-04-08 11:26   ` Duy Nguyen
2016-04-08 22:16     ` David Turner
2016-04-11 23:27       ` David Turner
2016-04-12  9:40         ` Duy Nguyen
2016-04-12 17:28           ` David Turner
2016-04-12 18:05             ` Junio C Hamano
2016-04-13  0:32               ` David Turner
2016-04-14 10:43               ` Duy Nguyen
2016-04-14 18:12                 ` Junio C Hamano
2016-04-14 18:20                   ` David Turner
2016-04-15  0:16                   ` Duy Nguyen
2016-04-15  1:31                     ` Junio C Hamano
2016-04-06 22:11 ` [PATCH v3 04/16] index-helper: add --strict David Turner
2016-04-06 22:11 ` [PATCH v3 05/16] daemonize(): set a flag before exiting the main process David Turner
2016-04-06 22:11 ` [PATCH v3 06/16] index-helper: add --detach David Turner
2016-04-06 22:11 ` [PATCH v3 07/16] read-cache: add watchman 'WAMA' extension David Turner
2016-04-06 22:11 ` [PATCH v3 08/16] Add watchman support to reduce index refresh cost David Turner
2016-04-06 22:11 ` [PATCH v3 09/16] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-07 22:47   ` Junio C Hamano
2016-04-07 22:52     ` Junio C Hamano
2016-04-08  0:14       ` David Turner
2016-04-08  6:03         ` Junio C Hamano
2016-04-06 22:11 ` [PATCH v3 10/16] update-index: enable/disable watchman support David Turner
2016-04-06 22:11 ` [PATCH v3 11/16] unpack-trees: preserve index extensions David Turner
2016-04-06 22:11 ` [PATCH v3 12/16] index-helper: kill mode David Turner
2016-04-06 22:11 ` [PATCH v3 13/16] index-helper: don't run if already running David Turner
2016-04-06 22:12 ` [PATCH v3 14/16] index-helper: autorun mode David Turner
2016-04-06 22:12 ` [PATCH v3 15/16] index-helper: optionally automatically run David Turner
2016-04-06 22:12 ` [PATCH v3 16/16] read-cache: config for waiting for index-helper David Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1604071614250.2967@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=aevarb@gmail.com \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=jeffhost@microsoft.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).