From: David Turner <dturner@twopensource.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
aevarb@gmail.com, jeffhost@microsoft.com
Subject: Re: [PATCH v3 03/16] index-helper: new daemon for caching index and related stuff
Date: Fri, 08 Apr 2016 18:16:24 -0400 [thread overview]
Message-ID: <1460153784.5540.19.camel@twopensource.com> (raw)
In-Reply-To: <CACsJy8C5NhaAAW=wzpwkBdLvVZz8wVM7QX==n_CL5g+LLAKY=A@mail.gmail.com>
On Fri, 2016-04-08 at 18:26 +0700, Duy Nguyen wrote:
> On Thu, Apr 7, 2016 at 5:11 AM, David Turner <
> dturner@twopensource.com> wrote:
> > @@ -1045,4 +1046,21 @@ struct tm *git_gmtime_r(const time_t *,
> > struct tm *);
> > #define getc_unlocked(fh) getc(fh)
> > #endif
> >
> > +#ifdef __linux__
> > +#define UNIX_PATH_MAX 108
> > +#elif defined(__APPLE__) || defined(BSD)
> > +#define UNIX_PATH_MAX 104
> > +#else
> > +/*
> > + * Quoth POSIX: The size of sun_path has intentionally been left
> > + * undefined. This is because different implementations use
> > different
> > + * sizes. For example, 4.3 BSD uses a size of 108, and 4.4 BSD
> > uses a
> > + * size of 104. Since most implementations originate from BSD
> > + * versions, the size is typically in the range 92 to 108.
> > + *
> > + * Thanks, POSIX! Super-helpful! Hope we don't overflow any
> > buffers!
> > + */
> > +#define UNIX_PATH_MAX 92
> > +#endif
>
> Okay. You probably want to fix unix-socket.c too, and maybe reuse
> that
> code instead of opening unix sockets manually. There's a check in
> unix_sockaddr_init() about sizeof(sun_path) but I'm not sure if it
> suffices.
>
> BTW, it looks like you tested this on Mac. But config.mak.uname only
> enables HAVE_SHM on Linux. Should it be enabled on Mac as well at
> least?
I did not in fact test on Mac. I should have. And indeed I need to
change config.mak.uname.
Also I was leaking some memory. And had some whiny warnings. And had
a bug around how non-blocking sockets work on Mac.
And SHM on Macs works a bit differently than on Linux in at least two
irritating ways.
So, uh, new version to come once I actually make it work on Mac.
Probably Monday.
next prev parent reply other threads:[~2016-04-08 22:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 22:11 [PATCH v3 00/16] index-helper, watchman David Turner
2016-04-06 22:11 ` [PATCH v3 01/16] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-06 22:11 ` [PATCH v3 02/16] read-cache: allow to keep mmap'd memory after reading David Turner
2016-04-06 22:11 ` [PATCH v3 03/16] index-helper: new daemon for caching index and related stuff David Turner
2016-04-07 6:21 ` Johannes Sixt
2016-04-07 14:14 ` Johannes Schindelin
2016-04-07 18:47 ` David Turner
2016-04-08 14:17 ` Johannes Schindelin
2016-04-08 11:26 ` Duy Nguyen
2016-04-08 22:16 ` David Turner [this message]
2016-04-11 23:27 ` David Turner
2016-04-12 9:40 ` Duy Nguyen
2016-04-12 17:28 ` David Turner
2016-04-12 18:05 ` Junio C Hamano
2016-04-13 0:32 ` David Turner
2016-04-14 10:43 ` Duy Nguyen
2016-04-14 18:12 ` Junio C Hamano
2016-04-14 18:20 ` David Turner
2016-04-15 0:16 ` Duy Nguyen
2016-04-15 1:31 ` Junio C Hamano
2016-04-06 22:11 ` [PATCH v3 04/16] index-helper: add --strict David Turner
2016-04-06 22:11 ` [PATCH v3 05/16] daemonize(): set a flag before exiting the main process David Turner
2016-04-06 22:11 ` [PATCH v3 06/16] index-helper: add --detach David Turner
2016-04-06 22:11 ` [PATCH v3 07/16] read-cache: add watchman 'WAMA' extension David Turner
2016-04-06 22:11 ` [PATCH v3 08/16] Add watchman support to reduce index refresh cost David Turner
2016-04-06 22:11 ` [PATCH v3 09/16] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-07 22:47 ` Junio C Hamano
2016-04-07 22:52 ` Junio C Hamano
2016-04-08 0:14 ` David Turner
2016-04-08 6:03 ` Junio C Hamano
2016-04-06 22:11 ` [PATCH v3 10/16] update-index: enable/disable watchman support David Turner
2016-04-06 22:11 ` [PATCH v3 11/16] unpack-trees: preserve index extensions David Turner
2016-04-06 22:11 ` [PATCH v3 12/16] index-helper: kill mode David Turner
2016-04-06 22:11 ` [PATCH v3 13/16] index-helper: don't run if already running David Turner
2016-04-06 22:12 ` [PATCH v3 14/16] index-helper: autorun mode David Turner
2016-04-06 22:12 ` [PATCH v3 15/16] index-helper: optionally automatically run David Turner
2016-04-06 22:12 ` [PATCH v3 16/16] read-cache: config for waiting for index-helper David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460153784.5540.19.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=aevarb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).