From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit: resurrect "gc --auto" at the end
Date: Wed, 14 May 2008 19:40:02 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0805141939470.30431@racer> (raw)
In-Reply-To: <7vlk2coist.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, 14 May 2008, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Wed, 2 Apr 2008, Johannes Schindelin wrote:
> >
> >> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >>
> >> As the scripted version of git-commit did, we now call gc --auto just
> >> before the post-commit hook.
> >>
> >> Any errors of gc --auto should be non-fatal, so we do not catch those; the
> >> user should see them anyway.
> >>
> >> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> >> ---
> >>
> >> Junio wrote:
> >> >
> >> > * "git commit" used to have one [call to 'gc --auto'] at the
> >> > end in the scripted version, but seems to have lost it in C
> >> > rewrite.
> >>
> >> How about this?
> >
> > Any news on this?
>
> I had an impression that we accepted the hook which made "gc --auto"
> more expensive by forcing it to check the hook (and possibly execute it
> every time) after vetting am, svn and friends to make sure nobody
> triggered "gc --auto" once per every commit, and during that vetting
> process we noticed that "git commit" lost the "gc --auto" at the end.
Ah yes, completely forgot. Thanks.
Ciao,
Dscho
next prev parent reply other threads:[~2008-05-14 18:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-30 23:14 [PATCH] git gc --auto: defer on battery Miklos Vajna
2008-03-30 23:26 ` Björn Steinbrink
2008-03-30 23:39 ` Miklos Vajna
2008-03-30 23:55 ` Björn Steinbrink
2008-03-30 23:46 ` Linus Torvalds
2008-03-31 0:00 ` Björn Steinbrink
2008-03-31 2:06 ` Junio C Hamano
2008-03-31 15:02 ` Linus Torvalds
2008-03-31 16:43 ` Björn Steinbrink
2008-03-31 17:00 ` fetchmail (Re: [PATCH] git gc --auto: defer on battery) Linus Torvalds
2008-04-02 13:40 ` [PATCH] commit: resurrect "gc --auto" at the end Johannes Schindelin
2008-05-14 15:07 ` Johannes Schindelin
2008-05-14 18:13 ` Junio C Hamano
2008-05-14 18:40 ` Johannes Schindelin [this message]
2008-05-15 6:44 ` Holger Schurig
2008-03-31 9:35 ` [PATCH 0/4] add pre-auto-gc hook for git-gc --auto Miklos Vajna
2008-03-31 9:35 ` [PATCH 1/4] git-gc --auto: add pre-auto-gc hook Miklos Vajna
2008-03-31 9:36 ` [PATCH 2/4] git-gc: add a --no-verify option to bypass the " Miklos Vajna
2008-03-31 9:36 ` [PATCH 3/4] Documentation/hooks: add " Miklos Vajna
2008-03-31 9:37 ` [PATCH 4/4] templates: add an example " Miklos Vajna
2008-03-31 18:30 ` Brian Gernhardt
2008-03-31 18:08 ` [PATCH] git gc --auto: defer on battery Joey Hess
2008-03-30 23:41 ` Johannes Schindelin
2008-03-30 23:53 ` Miklos Vajna
2008-03-31 16:24 ` Brandon Casey
2008-03-31 17:38 ` Miklos Vajna
2008-03-31 18:31 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0805141939470.30431@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).