git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Miklos Vajna <vmiklos@frugalware.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: [PATCH 1/4] git-gc --auto: add pre-auto-gc hook
Date: Mon, 31 Mar 2008 11:35:46 +0200	[thread overview]
Message-ID: <7637ee64f43964d2e514c1598b2e7783d71b8608.1206929014.git.vmiklos@frugalware.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0803301645020.14670@woody.linux-foundation.org>

If such a hook is available and exits with a non-zero status, then
git-gc --auto won't run.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 builtin-gc.c |   22 ++++++++++++++++++++++
 1 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/builtin-gc.c b/builtin-gc.c
index 8cef36f..acd63be 100644
--- a/builtin-gc.c
+++ b/builtin-gc.c
@@ -157,6 +157,25 @@ static int too_many_packs(void)
 	return gc_auto_pack_limit <= cnt;
 }
 
+static int run_hook()
+{
+	const char *argv[2];
+	struct child_process hook;
+
+	argv[0] = git_path("hooks/pre-auto-gc");
+	argv[1] = NULL;
+
+	if (access(argv[0], X_OK) < 0)
+		return 0;
+
+	memset(&hook, 0, sizeof(hook));
+	hook.argv = argv;
+	hook.no_stdin = 1;
+	hook.stdout_to_stderr = 1;
+
+	return run_command(&hook);
+}
+
 static int need_to_gc(void)
 {
 	/*
@@ -176,6 +195,9 @@ static int need_to_gc(void)
 		append_option(argv_repack, "-A", MAX_ADD);
 	else if (!too_many_loose_objects())
 		return 0;
+
+	if (run_hook())
+		return 0;
 	return 1;
 }
 
-- 
1.5.5.rc2.4.g283c6

  parent reply	other threads:[~2008-03-31  9:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-30 23:14 [PATCH] git gc --auto: defer on battery Miklos Vajna
2008-03-30 23:26 ` Björn Steinbrink
2008-03-30 23:39   ` Miklos Vajna
2008-03-30 23:55     ` Björn Steinbrink
2008-03-30 23:46   ` Linus Torvalds
2008-03-31  0:00     ` Björn Steinbrink
2008-03-31  2:06     ` Junio C Hamano
2008-03-31 15:02       ` Linus Torvalds
2008-03-31 16:43         ` Björn Steinbrink
2008-03-31 17:00           ` fetchmail (Re: [PATCH] git gc --auto: defer on battery) Linus Torvalds
2008-04-02 13:40       ` [PATCH] commit: resurrect "gc --auto" at the end Johannes Schindelin
2008-05-14 15:07         ` Johannes Schindelin
2008-05-14 18:13           ` Junio C Hamano
2008-05-14 18:40             ` Johannes Schindelin
2008-05-15  6:44             ` Holger Schurig
2008-03-31  9:35     ` [PATCH 0/4] add pre-auto-gc hook for git-gc --auto Miklos Vajna
2008-03-31  9:35     ` Miklos Vajna [this message]
2008-03-31  9:36     ` [PATCH 2/4] git-gc: add a --no-verify option to bypass the pre-auto-gc hook Miklos Vajna
2008-03-31  9:36     ` [PATCH 3/4] Documentation/hooks: add " Miklos Vajna
2008-03-31  9:37     ` [PATCH 4/4] templates: add an example " Miklos Vajna
2008-03-31 18:30       ` Brian Gernhardt
2008-03-31 18:08     ` [PATCH] git gc --auto: defer on battery Joey Hess
2008-03-30 23:41 ` Johannes Schindelin
2008-03-30 23:53   ` Miklos Vajna
2008-03-31 16:24 ` Brandon Casey
2008-03-31 17:38   ` Miklos Vajna
2008-03-31 18:31     ` Brandon Casey
     [not found] <7637ee64f43964d2e514c1598b2e7783d71b8608.1206929014.git.vmiklos @frugalware.org>
2008-04-01  4:51 ` [PATCH 1/4] git-gc --auto: add pre-auto-gc hook Junio C Hamano
2008-04-01 11:39   ` Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7637ee64f43964d2e514c1598b2e7783d71b8608.1206929014.git.vmiklos@frugalware.org \
    --to=vmiklos@frugalware.org \
    --cc=B.Steinbrink@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).