git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Atharva Raykar <raykar.ath@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
	Shourya Shukla <periperidip@gmail.com>,
	Git List <git@vger.kernel.org>
Subject: Re: [GSoC] My Git Dev Blog - Week 5
Date: Mon, 21 Jun 2021 00:46:32 +0530	[thread overview]
Message-ID: <ac381db1-fb14-2a23-cfee-863840b89493@gmail.com> (raw)
In-Reply-To: <D32894F5-FC76-4DD2-A2F6-E69AAE88C645@gmail.com>

On 19/06/21 7:02 pm, Atharva Raykar wrote:
> Here's the latest instalment of my weekly Git blog:
> http://atharvaraykar.me/gitnotes/week5
>

Nice blog.
  
> A peek at what's inside:
> 
>   * The blog starts with a summary of all the relevant things
>     that have happened so far in my time with Git, including
>     the status of my submodule-related work.
> 
>   * A question I had about reading the index into memory
>     (any kind of help would be appreciated!):
>     http://atharvaraykar.me/gitnotes/week5#some-challenges-with-the-changes-that-are-cooking
> 

I've tried to clarify this to an extent in a comment [1] on your branch.

A few other things:

> After Rafael and Eric commented on my patch, I forgot to CC them when
> I rerolled. New contributors: please check your CC’s before hitting send!

To add to that, Cc-ing people in the e-mail of all the patches in the series
and not just in the cover letter would be nice too. :) Of course, if you have
a specific reason to not do that, then it's fine.

> And my other blooper was to forget signing off one of my patches. Oops.

Are you aware of `format.signOff` [2] which could save you from issues
like these?


[1]: https://github.com/tfidfwastaken/git/commit/3c46c108a195c42edaab939ab6dd6731e52aefc3#r52396546

[2]: https://git-scm.com/docs/git-config#Documentation/git-config.txt-formatsignOff

-- 
Sivaraam

  parent reply	other threads:[~2021-06-20 19:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 13:32 [GSoC] My Git Dev Blog - Week 5 Atharva Raykar
2021-06-20  5:52 ` Christian Couder
2021-06-21  6:20   ` Atharva Raykar
2021-06-20 19:16 ` Kaartic Sivaraam [this message]
2021-06-21  6:28   ` Atharva Raykar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac381db1-fb14-2a23-cfee-863840b89493@gmail.com \
    --to=kaartic.sivaraam@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=periperidip@gmail.com \
    --cc=raykar.ath@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).