Re: [GSoC] My Git Dev Blog - Week 5

[Atharva Raykar <raykar.ath@gmail.com>]

On 21-Jun-2021, at 00:46, Kaartic Sivaraam <kaartic.sivaraam@gmail.com> wrote:
> 
> On 19/06/21 7:02 pm, Atharva Raykar wrote:
>> Here's the latest instalment of my weekly Git blog:
>> http://atharvaraykar.me/gitnotes/week5
>> 
> 
> Nice blog.
> 
>> A peek at what's inside:
>>  * The blog starts with a summary of all the relevant things
>>    that have happened so far in my time with Git, including
>>    the status of my submodule-related work.
>>  * A question I had about reading the index into memory
>>    (any kind of help would be appreciated!):
>>    http://atharvaraykar.me/gitnotes/week5#some-challenges-with-the-changes-that-are-cooking
> 
> I've tried to clarify this to an extent in a comment [1] on your branch.

Thanks, I'll have a look.

> A few other things:
> 
>> After Rafael and Eric commented on my patch, I forgot to CC them when
>> I rerolled. New contributors: please check your CC’s before hitting send!
> 
> To add to that, Cc-ing people in the e-mail of all the patches in the series
> and not just in the cover letter would be nice too. :) Of course, if you have
> a specific reason to not do that, then it's fine.

Okay, I will remember to do this.

>> And my other blooper was to forget signing off one of my patches. Oops.
> 
> Are you aware of `format.signOff` [2] which could save you from issues
> like these?

Thanks, this should have been in my config all along. Unfortunately,
it won't be possible to automate adding the other trailers in my
patches, unless Git learns to read my mind ;-)

> 
> [1]: https://github.com/tfidfwastaken/git/commit/3c46c108a195c42edaab939ab6dd6731e52aefc3#r52396546
> 
> [2]: https://git-scm.com/docs/git-config#Documentation/git-config.txt-formatsignOff
> 
> -- 
> Sivaraam