From: Alban Gruin <alban.gruin@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Cc: Phillip Wood <phillip.wood@talktalk.net>,
phillip.wood@dunelm.org.uk, Michal Nowak <mnowak@startmail.com>,
git@vger.kernel.org
Subject: Re: Broken interactive rebase text after some UTF-8 characters
Date: Fri, 1 Feb 2019 17:13:13 +0100 [thread overview]
Message-ID: <a3f4a6d2-7461-709a-6d1a-097785bb8664@gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1902010835210.41@tvgsbejvaqbjf.bet>
Hi Johannes,
Le 01/02/2019 à 08:38, Johannes Schindelin a écrit :
> Hi,
>
> On Thu, 31 Jan 2019, Junio C Hamano wrote:
>
>> Phillip Wood <phillip.wood@talktalk.net> writes:
>>
>>>> Are we misusing C formats?
>>>
>>> The C standard and POSIX both say that the * refers to the maximum
>>> number of bytes to print but it looks like it is being treated as the
>>> maximum number of characters on OpenIndiana.
>>>
>>> Johannes - Perhaps we should change it to use fwrite() unless printf()
>>> gets fixed and we're sure no other operating systems are affected?
>>
>> Avoid such a rewrite, as "%*.s" that takes (int, char *) are used in
>> many other places in our codebase, if you can.
>
> Yes, this would be painful in particular in cases like
>
> master:advice.c:101: fprintf(stderr, _("%shint: %.*s%s\n"),
>
> where we want to write more than just a variable-length buffer.
>
> I am curious: is libintl (gettext) used on OpenIndiana? I ask because
> AFAIR fprintf() is overridden in that case, and the bug might be a lot
> easier to fix if it is in libintl rather than in libc.
>
> Of course, it might *still* be a bug in libc by virtue of handing '%.*s'
> through to libc's implementation.
>
> Alban, can you test this with NO_GETTEXT?
Sure. :)
The bug no longer happens when git is built with NO_GETTEXT. All is
working as expected.
>
> Thanks,
> Johannes
>
Cheers,
Alban
prev parent reply other threads:[~2019-02-01 16:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 19:29 Broken interactive rebase text after some UTF-8 characters Michal Nowak
2019-01-16 10:33 ` Phillip Wood
2019-01-16 21:36 ` Michal Nowak
2019-01-17 11:04 ` Phillip Wood
2019-01-31 17:43 ` Alban Gruin
2019-01-31 20:40 ` Phillip Wood
2019-01-31 21:00 ` Alban Gruin
2019-01-31 21:35 ` Junio C Hamano
2019-02-01 7:38 ` Johannes Schindelin
2019-02-01 9:06 ` Michal Nowak
2019-02-01 14:33 ` Johannes Schindelin
2019-02-01 16:24 ` Michal Nowak
2019-02-01 17:30 ` Junio C Hamano
2019-02-01 19:00 ` Michal Nowak
2019-02-01 16:15 ` Alban Gruin
2019-02-01 16:13 ` Alban Gruin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3f4a6d2-7461-709a-6d1a-097785bb8664@gmail.com \
--to=alban.gruin@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mnowak@startmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=phillip.wood@talktalk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).