From: Phillip Wood <phillip.wood@talktalk.net>
To: Alban Gruin <alban.gruin@gmail.com>,
phillip.wood@dunelm.org.uk, Michal Nowak <mnowak@startmail.com>,
git@vger.kernel.org
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: Broken interactive rebase text after some UTF-8 characters
Date: Thu, 31 Jan 2019 20:40:43 +0000 [thread overview]
Message-ID: <2cbb5818-643d-bafd-6721-91e0d291a5fd@talktalk.net> (raw)
In-Reply-To: <505c2e2e-c9bc-aa57-c498-2acced0b8afa@gmail.com>
Hi Alban
On 31/01/2019 17:43, Alban Gruin wrote:
> Hi Phillip and Michal,
>
> I think I found the bug.
Good find! Which os are you on?
>
> If you look at .git/rebase-merge/git-rebase-todo.backup, which is
> created before the editor is opened, you can see that it does not have
> this problem. In between, transform_todos() is called and causes the
> problem reported by Michal.
>
> This seems to be caused by a single line, sequencer:4661 (on b5101f9297,
> "Fourth batch after 2.20", 2019-01-29)[1]. If you add just before a
> something like this:
>
> fwrite(item->arg, item->arg_len, sizeof(char), stdout);
>
> You will see that the argument is properly written to stdout. But if
> you write this:
>
> printf("%.*s\n", item->arg_len, item->arg);
>
> You will have the same broken output as in the todo file.
>
> Are we misusing C formats?
The C standard and POSIX both say that the * refers to the maximum
number of bytes to print but it looks like it is being treated as the
maximum number of characters on OpenIndiana.
Johannes - Perhaps we should change it to use fwrite() unless printf()
gets fixed and we're sure no other operating systems are affected?
[1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html
[2] http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1548.pdf page 309
Best Wishes
Phillip
> [1] https://github.com/git/git/blob/master/sequencer.c#L4661
>
> Cheers,
> Alban
>
>
next prev parent reply other threads:[~2019-01-31 20:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 19:29 Broken interactive rebase text after some UTF-8 characters Michal Nowak
2019-01-16 10:33 ` Phillip Wood
2019-01-16 21:36 ` Michal Nowak
2019-01-17 11:04 ` Phillip Wood
2019-01-31 17:43 ` Alban Gruin
2019-01-31 20:40 ` Phillip Wood [this message]
2019-01-31 21:00 ` Alban Gruin
2019-01-31 21:35 ` Junio C Hamano
2019-02-01 7:38 ` Johannes Schindelin
2019-02-01 9:06 ` Michal Nowak
2019-02-01 14:33 ` Johannes Schindelin
2019-02-01 16:24 ` Michal Nowak
2019-02-01 17:30 ` Junio C Hamano
2019-02-01 19:00 ` Michal Nowak
2019-02-01 16:15 ` Alban Gruin
2019-02-01 16:13 ` Alban Gruin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cbb5818-643d-bafd-6721-91e0d291a5fd@talktalk.net \
--to=phillip.wood@talktalk.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
--cc=mnowak@startmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).