From: Michael Haggerty <mhagger@alum.mit.edu>
To: Jeff King <peff@peff.net>, Marc Branchaud <marcnarc@xiplink.com>
Cc: git@vger.kernel.org, Stefan Beller <sbeller@google.com>
Subject: Re: [PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic.
Date: Sun, 30 Apr 2017 05:26:41 +0200 [thread overview]
Message-ID: <a0d14b53-01c2-c653-15c9-ff566d24a782@alum.mit.edu> (raw)
In-Reply-To: <20170429124052.yhgwofbbd5pkd24p@sigill.intra.peff.net>
On 04/29/2017 02:40 PM, Jeff King wrote:
> On Fri, Apr 28, 2017 at 06:33:12PM -0400, Marc Branchaud wrote:
>
>> v2: Fixed up the commit messages and added tests.
>>
>> Marc Branchaud (2):
>> diff: make the indent heuristic part of diff's basic configuration
>> diff: have the diff-* builtins configure diff before initializing
>> revisions
>>
>> Stefan Beller (1):
>> diff: enable indent heuristic by default
>
> Thanks, these look fine to me. I'd like to get an ACK from Michael, in
> case he had some other reason for omitting them from git_diff_ui_config
> (from my recollection, it's probably just a mix of conservatism and
> following what the compaction heuristic had done).
That's exactly right. The only discussion I remember about broadening
the scope of diff options was with regards to `blame` [1]. I don't
really have enough overview of these configuration topics to have much
an opinion.
Michael
[1]
http://public-inbox.org/git/xmqqtwebwhbg.fsf@gitster.mtv.corp.google.com/
prev parent reply other threads:[~2017-04-30 3:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 17:21 BUG: diff-{index,files,tree} (and git-gui) do not respect the diff.indentHeuristic config setting Marc Branchaud
2017-04-25 21:27 ` Jeff King
2017-04-27 20:50 ` [PATCH 0/2] Make diff plumbing commands respect the indentHeuristic Marc Branchaud
2017-04-27 20:50 ` [PATCH 1/2] Make the indent heuristic part of diff's basic configuration Marc Branchaud
2017-04-28 7:59 ` Jeff King
2017-04-27 20:50 ` [PATCH 2/2] Have the diff-* builtins configure diff before initializing revisions Marc Branchaud
2017-04-28 8:06 ` Jeff King
2017-05-01 1:01 ` Junio C Hamano
2017-05-01 5:17 ` Jeff King
2017-05-01 5:29 ` Jeff King
2017-04-28 7:56 ` [PATCH 0/2] Make diff plumbing commands respect the indentHeuristic Jeff King
2017-04-28 17:34 ` Stefan Beller
2017-04-28 22:04 ` Jeff King
2017-04-28 22:13 ` Stefan Beller
2017-05-01 10:34 ` Ævar Arnfjörð Bjarmason
2017-05-09 3:16 ` Jeff King
2017-05-09 4:06 ` Junio C Hamano
2017-05-09 7:58 ` Ævar Arnfjörð Bjarmason
2017-05-09 8:04 ` Jeff King
2017-04-28 22:33 ` [PATCHv2 0/3] " Marc Branchaud
2017-04-28 22:33 ` [PATCHv2 1/3] diff: make the indent heuristic part of diff's basic configuration Marc Branchaud
2017-04-28 22:33 ` [PATCHv2 2/3] diff: have the diff-* builtins configure diff before initializing revisions Marc Branchaud
2017-04-28 22:33 ` [PATCH 3/3] diff: enable indent heuristic by default Marc Branchaud
2017-04-29 12:40 ` [PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic Jeff King
2017-04-29 13:14 ` Jeff King
2017-05-01 1:11 ` Junio C Hamano
2017-05-01 5:15 ` Jeff King
2017-05-01 23:25 ` Junio C Hamano
2017-05-01 22:13 ` [PATCHv3 0/4] " Marc Branchaud
2017-05-01 22:13 ` [PATCHv3 1/4] diff: make the indent heuristic part of diff's basic configuration Marc Branchaud
2017-05-01 22:13 ` [PATCHv3 2/4] diff: have the diff-* builtins configure diff before initializing revisions Marc Branchaud
2017-05-01 22:13 ` [PATCHv3 3/4] diff: enable indent heuristic by default Marc Branchaud
2017-05-01 22:20 ` Jeff King
2017-05-01 22:13 ` [PATCHv3 4/4] add--interactive: drop diff.indentHeuristic handling Marc Branchaud
2017-05-01 22:18 ` [PATCHv3 0/4] Make diff plumbing commands respect the indentHeuristic Stefan Beller
2017-04-29 13:15 ` [PATCH 4/3] add--interactive: drop diff.indentHeuristic handling Jeff King
2017-04-30 3:26 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0d14b53-01c2-c653-15c9-ff566d24a782@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=marcnarc@xiplink.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).