From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: What's cooking in git.git (Feb 2024, #02; Fri, 2)
Date: Mon, 5 Feb 2024 17:39:13 -0500 [thread overview]
Message-ID: <ZcFjkfbsBfk7JQIH@nand.local> (raw)
In-Reply-To: <xmqqmssirm6t.fsf@gitster.g>
On Sat, Feb 03, 2024 at 12:23:06AM -0800, Junio C Hamano wrote:
> * tb/pair-chunk-expect (2023-11-10) 8 commits
> - midx: read `OOFF` chunk with `pair_chunk_expect()`
> - midx: read `OIDL` chunk with `pair_chunk_expect()`
> - commit-graph: read `BIDX` chunk with `pair_chunk_expect()`
> - commit-graph: read `GDAT` chunk with `pair_chunk_expect()`
> - commit-graph: read `CDAT` chunk with `pair_chunk_expect()`
> - commit-graph: read `OIDL` chunk with `pair_chunk_expect()`
> - chunk-format: introduce `pair_chunk_expect()` helper
> - Merge branch 'jk/chunk-bounds-more' into HEAD
>
> Further code clean-up.
>
> Needs review.
> source: <cover.1699569246.git.me@ttaylorr.com>
Let's drop this one. It's been sitting on my backlog for almost four
months, and I don't think it's going to be a priority for me to finish
in the near future.
After spending some time offline thinking about it, I'm not convinced
that it substantially hardens the chunk-format code anyway, so I'd
probably just as soon drop it from your queue.
>
> * tb/path-filter-fix (2024-01-31) 16 commits
> - bloom: introduce `deinit_bloom_filters()`
> - commit-graph: reuse existing Bloom filters where possible
> - object.h: fix mis-aligned flag bits table
> - commit-graph: new Bloom filter version that fixes murmur3
> - commit-graph: unconditionally load Bloom filters
> - bloom: prepare to discard incompatible Bloom filters
> - bloom: annotate filters with hash version
> - repo-settings: introduce commitgraph.changedPathsVersion
> - t4216: test changed path filters with high bit paths
> - t/helper/test-read-graph: implement `bloom-filters` mode
> - bloom.h: make `load_bloom_filter_from_graph()` public
> - t/helper/test-read-graph.c: extract `dump_graph_info()`
> - gitformat-commit-graph: describe version 2 of BDAT
> - commit-graph: ensure Bloom filters are read with consistent settings
> - revision.c: consult Bloom filters for root commits
> - t/t4216-log-bloom.sh: harden `test_bloom_filters_not_used()`
>
> The Bloom filter used for path limited history traversal was broken
> on systems whose "char" is unsigned; update the implementation and
> bump the format version to 2.
> source: <cover.1706741516.git.me@ttaylorr.com>
This version should be ready, but given how egregious the mistake I made
in the last round was, I'd love to SZEDER to take a look before I
recommend merging it down.
Thanks,
Taylor
prev parent reply other threads:[~2024-02-05 22:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 8:23 What's cooking in git.git (Feb 2024, #02; Fri, 2) Junio C Hamano
2024-02-05 18:57 ` Phillip Wood
2024-02-05 23:20 ` Junio C Hamano
2024-02-06 13:56 ` Phillip Wood
2024-02-05 22:39 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcFjkfbsBfk7JQIH@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).