From: Phillip Wood <phillip.wood123@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Feb 2024, #02; Fri, 2)
Date: Mon, 5 Feb 2024 18:57:49 +0000 [thread overview]
Message-ID: <087d3438-98a1-46fe-89d9-8e7e1662151b@gmail.com> (raw)
In-Reply-To: <xmqqmssirm6t.fsf@gitster.g>
Hi Junio
On 03/02/2024 08:23, Junio C Hamano wrote:
> * kn/for-all-refs (2024-01-29) 4 commits
> (merged to 'next' on 2024-01-30 at e7a9234a8b)
> + for-each-ref: avoid filtering on empty pattern
> + refs: introduce `refs_for_each_all_refs()`
> + refs: extract out `loose_fill_ref_dir_regular_file()`
> + refs: introduce `is_pseudoref()` and `is_headref()`
>
> "git for-each-ref" filters its output with prefixes given from the
> command line, but it did not honor an empty string to mean "pass
> everything", which has been corrected.
I've been a bit slow to look at the latest re-roll but having done so
I'm concerned that the UI could use some improvement. If I understand
correctly the proposal is to make
git for-each-ref
and
git for-each-ref ""
behave differently so that the latter prints the pseudorefs from the
current worktree and the former does not. I can't help feeling that's
the sort of thing that makes people complain that git is hard to
understand. I wonder if we'd be better off adding an option to include
pseudorefs and have an empty pattern behave the same as no pattern.
Best Wishes
Phillip
> Will merge to 'master'.
> source: <20240129113527.607022-1-karthik.188@gmail.com>
next prev parent reply other threads:[~2024-02-05 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 8:23 What's cooking in git.git (Feb 2024, #02; Fri, 2) Junio C Hamano
2024-02-05 18:57 ` Phillip Wood [this message]
2024-02-05 23:20 ` Junio C Hamano
2024-02-06 13:56 ` Phillip Wood
2024-02-05 22:39 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=087d3438-98a1-46fe-89d9-8e7e1662151b@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).