From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Dinesh Dharmawardena <dinesh_dh@outlook.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Let us not call it git blame
Date: Fri, 3 Mar 2023 01:31:05 +0000 [thread overview]
Message-ID: <ZAFN2ZoOQzUC/nHo@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqfsamiul2.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 2053 bytes --]
On 2023-03-02 at 23:47:53, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > On 2023-03-02 at 22:00:59, Dinesh Dharmawardena wrote:
> >>
> >> I am writing to you to request that the term blame in git blame
> >> be replaced with something that does not sound so blameful. I’m
> >> an SRE and we actively try promote a blameless culture as such
> >> industry tooling should also follow suit imo. Progressively
> >> phasing this term out with a better alias would be great.
>
> I actually do not think "git blame" is incompatible with blameless
> culture at all, unless you blindly say "this word is bad, that word
> is not" without thinking. Blameless culture is about not blaming
> the _person_ who made an earlier mistake, but "git blame" is not
> about finding a person who contributed the badness to the codebase.
>
> It is all about which _commit_ contributed badness to the current
> codebase (i.e. "these commits are to be blamed for the current
> breakage that made us lose $XM") and it is up to the users how to
> interpret the story behind these found commits. It often would not
> be the "fault" of the author alone, and striving for blameless
> culture is to find out what led to the mistakes in these commits.
I don't even think it's that all the time. Sometimes I've used git
blame to find the author of a commit to ask them questions about a
comment or change later on, or to find a commit message or pull request
to understand why a change was made.
I'm almost always more interested in learning more about the rationale
or reasoning for a commit than blaming a particular user. I have used
git blame in the past to find the _team_ that introduced a regression
for assigning bugs in triage when the cause is clear (since they'd have
the relevant context to understand the necessary change better), but
it's very uncommon that I actually use it in anger to blame to a
particular person.
--
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2023-03-03 1:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SY6P282MB3782FD975E6F39951C5A43DA92B29@SY6P282MB3782.AUSP282.PROD.OUTLOOK.COM>
2023-03-02 22:00 ` Let us not call it git blame Dinesh Dharmawardena
2023-03-02 22:16 ` brian m. carlson
2023-03-02 23:47 ` Junio C Hamano
2023-03-03 0:07 ` rsbecker
2023-03-03 8:55 ` demerphq
2023-03-03 1:31 ` brian m. carlson [this message]
2023-03-03 8:28 ` demerphq
2023-03-03 18:28 ` Peter Hadlaw
2023-03-07 12:08 ` Ævar Arnfjörð Bjarmason
2023-03-09 20:28 ` Elijah Lynn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAFN2ZoOQzUC/nHo@tapette.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=dinesh_dh@outlook.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).