git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>,
	"'brian m. carlson'" <sandals@crustytoothpaste.net>
Cc: "'Dinesh Dharmawardena'" <dinesh_dh@outlook.com>, <git@vger.kernel.org>
Subject: RE: Let us not call it git blame
Date: Thu, 2 Mar 2023 19:07:12 -0500	[thread overview]
Message-ID: <003201d94d64$1e732030$5b596090$@nexbridge.com> (raw)
In-Reply-To: <xmqqfsamiul2.fsf@gitster.g>

On Thursday, March 2, 2023 6:48 PM, Junio C Hamano wrote:
>"brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
>> On 2023-03-02 at 22:00:59, Dinesh Dharmawardena wrote:
>>>
>>> I am writing to you to request that the term blame in git blame be
>>> replaced with something that does not sound so blameful. I’m an SRE
>>> and we actively try promote a blameless culture as such industry
>>> tooling should also follow suit imo. Progressively phasing this term
>>> out with a better alias would be great.
>
>I actually do not think "git blame" is incompatible with blameless culture at all,
>unless you blindly say "this word is bad, that word is not" without thinking.  Blameless
>culture is about not blaming the _person_ who made an earlier mistake, but "git
>blame" is not about finding a person who contributed the badness to the codebase.
>
>It is all about which _commit_ contributed badness to the current codebase (i.e.
>"these commits are to be blamed for the current breakage that made us lose $XM")
>and it is up to the users how to interpret the story behind these found commits.  It
>often would not be the "fault" of the author alone, and striving for blameless culture
>is to find out what led to the mistakes in these commits.
>
>> I believe there's already an alias for it, git annotate, if you'd
>> prefer to use that.  The name "blame" came in with CVS, with the
>> synonym "annotate", so it's well understood, but you can use whichever
>> alias you prefer.
>>
>> I do think there may some differences in the defaults between git
>> annotate and git blame, but if someone wanted to send in a patch for
>> an option to make annotate produce identical output to blame, then I
>> think it could be a full replacement.
>
>At that point we can retire "git blame" and make it a built-in alias to "git annotate --
>behave-like-git-blame".  Then we will come full circle ;-)

I think you have a good point here. Blame is associated with the commit which is not a specific person (might be a group though). In some (a few, but growing) companies I am dealing with, the core.user and core.email are associated with a nameless single sign on (SSO), or tokenized user, in order to be compliant from a regulatory standpoint. This includes GDPR in Europe and the Privacy Act in Canada. In these cases, there is no identifying information in the commit itself, but externally in the organization's HR and IT departments where identifying information is tightly controlled. Cause and effect will always exist, no matter how one might choose to semantically hide the usage. Words do matter, but identifying information may not for much longer. Perhaps that approach might help the OP's organization in their jurisdiction, to dissociate the commit from the person except during a specific audit context.


  reply	other threads:[~2023-03-03  0:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <SY6P282MB3782FD975E6F39951C5A43DA92B29@SY6P282MB3782.AUSP282.PROD.OUTLOOK.COM>
2023-03-02 22:00 ` Let us not call it git blame Dinesh Dharmawardena
2023-03-02 22:16   ` brian m. carlson
2023-03-02 23:47     ` Junio C Hamano
2023-03-03  0:07       ` rsbecker [this message]
2023-03-03  8:55         ` demerphq
2023-03-03  1:31       ` brian m. carlson
2023-03-03  8:28   ` demerphq
2023-03-03 18:28   ` Peter Hadlaw
2023-03-07 12:08   ` Ævar Arnfjörð Bjarmason
2023-03-09 20:28   ` Elijah Lynn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003201d94d64$1e732030$5b596090$@nexbridge.com' \
    --to=rsbecker@nexbridge.com \
    --cc=dinesh_dh@outlook.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).