From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Derrick Stolee" <derrickstolee@github.com>
Subject: Re: [PATCH 0/2] git-compat-util.h: change UNUSED(var) to UNUSED
Date: Fri, 26 Aug 2022 03:52:06 -0400 [thread overview]
Message-ID: <Ywh7ppVFk6VK1Ybs@coredump.intra.peff.net> (raw)
In-Reply-To: <cover-0.2-00000000000-20220825T170709Z-avarab@gmail.com>
On Thu, Aug 25, 2022 at 07:09:47PM +0200, Ævar Arnfjörð Bjarmason wrote:
> Ævar Arnfjörð Bjarmason (2):
> git-compat-util.h: use "UNUSED", not "UNUSED(var)"
> git-compat-util.h: use "deprecated" for UNUSED variables
So I don't love this, as I do find the resulting syntax harder to read.
But I don't really see a way around it to keep coccinelle functioning,
so it seems like the best (only?) path forward.
The patches themselves look OK to me (though I admit my eyes glazed over
halfway through the first one; I assume you used a regex. I'll have to
do the same for the other 100+ patches I have in reserve).
-Peff
next prev parent reply other threads:[~2022-08-26 7:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 17:28 [PATCH] ci: update 'static-analysis' to Ubuntu 22.04 Derrick Stolee via GitGitGadget
2022-08-24 14:40 ` Johannes Schindelin
2022-08-24 19:59 ` Junio C Hamano
2022-08-24 23:43 ` Junio C Hamano
2022-08-25 0:30 ` Derrick Stolee
2022-08-25 4:43 ` Junio C Hamano
2022-08-25 10:47 ` Ævar Arnfjörð Bjarmason
2022-08-25 16:08 ` Junio C Hamano
2022-08-25 17:09 ` [PATCH 0/2] git-compat-util.h: change UNUSED(var) to UNUSED Ævar Arnfjörð Bjarmason
2022-08-25 17:09 ` [PATCH 1/2] git-compat-util.h: use "UNUSED", not "UNUSED(var)" Ævar Arnfjörð Bjarmason
2022-08-25 17:09 ` [PATCH 2/2] git-compat-util.h: use "deprecated" for UNUSED variables Ævar Arnfjörð Bjarmason
2022-08-26 7:52 ` Jeff King [this message]
2022-08-26 7:48 ` [PATCH] ci: update 'static-analysis' to Ubuntu 22.04 Jeff King
2022-08-26 16:46 ` Junio C Hamano
2022-08-27 12:58 ` Jeff King
2022-08-29 5:56 ` Junio C Hamano
2022-08-29 10:29 ` Ævar Arnfjörð Bjarmason
2022-08-31 15:12 ` Jeff King
2022-08-31 8:44 ` SZEDER Gábor
2022-08-31 12:13 ` Ævar Arnfjörð Bjarmason
2022-08-31 15:24 ` Jeff King
2022-08-31 19:19 ` Junio C Hamano
2022-08-31 18:05 ` SZEDER Gábor
2022-08-31 19:29 ` Ævar Arnfjörð Bjarmason
2022-08-25 14:57 ` Ævar Arnfjörð Bjarmason
2022-08-25 16:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywh7ppVFk6VK1Ybs@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).