From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH] ci: update 'static-analysis' to Ubuntu 22.04
Date: Thu, 25 Aug 2022 16:57:35 +0200 [thread overview]
Message-ID: <220825.865yig4bd7.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <pull.1334.git.1661275691795.gitgitgadget@gmail.com>
On Tue, Aug 23 2022, Derrick Stolee via GitGitGadget wrote:
> From: Derrick Stolee <derrickstolee@github.com>
>
> GitHub Actions scheduled a brownout of Ubuntu 18.04, which canceled all
> runs of the 'static-analysis' job in our CI runs. Update to 22.04 to
> avoid this as the brownout later turns into a complete deprecation.
>
> The use of 18.04 was set in d051ed77ee6 (.github/workflows/main.yml: run
> static-analysis on bionic, 2021-02-08) due to the lack of Coccinelle
> being available on 20.04 (which continues today).
>
> Signed-off-by: Derrick Stolee <derrickstolee@github.com>
> ---
> ci: update 'static-analysis' to Ubuntu 20.04
>
> I noticed this while preparing my bundle URIs series. See an example
> cancellation at [1]
>
> [1]
> https://github.com/gitgitgadget/git/runs/7954913465?check_suite_focus=true
>
> I initially asked about this [2]. Thanks to Matthias Aßhauer for
> pointing out that 22.04 has Coccinelle available [3].
>
> [2]
> https://lore.kernel.org/git/eb8779bc-fc41-f601-05f2-024e6bf3f316@github.com/
> [3]
> https://github.com/gitgitgadget/git/pull/1334#issuecomment-1223597655
>
> Thanks,
>
> * Stolee
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1334%2Fderrickstolee%2Fstatic-analysis-ubuntu-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1334/derrickstolee/static-analysis-ubuntu-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1334
>
> .github/workflows/main.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index cd1f52692a5..831f4df56c5 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -309,7 +309,7 @@ jobs:
> if: needs.ci-config.outputs.enabled == 'yes'
> env:
> jobname: StaticAnalysis
> - runs-on: ubuntu-18.04
> + runs-on: ubuntu-22.04
I think it's worth mentioning in the commit message that the reason
we're not going for "ubuntu-latest" here is because "latest" is a
misnomer, it's not the "latest", but "latest-stable" or
whatever. I.e. it's pointing to 20.04 currently:
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
I think per
https://lore.kernel.org/git/211104.86v918i78r.gmgdl@evledraar.gmail.com/
that we should pin these in general, but you/Junio disagreed at the
time. So maybe a commit message change/comment here noting "# make this
ubuntu-latest once it's ubuntu-22.04 or later" or something would make
the intent clearer.
Also: for "sparse" didn't we miss doing that, i.e. it's pinned on
ubuntu-20.04 explicitly, but surely that should be "ubuntu-latest" now?
next prev parent reply other threads:[~2022-08-25 15:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 17:28 [PATCH] ci: update 'static-analysis' to Ubuntu 22.04 Derrick Stolee via GitGitGadget
2022-08-24 14:40 ` Johannes Schindelin
2022-08-24 19:59 ` Junio C Hamano
2022-08-24 23:43 ` Junio C Hamano
2022-08-25 0:30 ` Derrick Stolee
2022-08-25 4:43 ` Junio C Hamano
2022-08-25 10:47 ` Ævar Arnfjörð Bjarmason
2022-08-25 16:08 ` Junio C Hamano
2022-08-25 17:09 ` [PATCH 0/2] git-compat-util.h: change UNUSED(var) to UNUSED Ævar Arnfjörð Bjarmason
2022-08-25 17:09 ` [PATCH 1/2] git-compat-util.h: use "UNUSED", not "UNUSED(var)" Ævar Arnfjörð Bjarmason
2022-08-25 17:09 ` [PATCH 2/2] git-compat-util.h: use "deprecated" for UNUSED variables Ævar Arnfjörð Bjarmason
2022-08-26 7:52 ` [PATCH 0/2] git-compat-util.h: change UNUSED(var) to UNUSED Jeff King
2022-08-26 7:48 ` [PATCH] ci: update 'static-analysis' to Ubuntu 22.04 Jeff King
2022-08-26 16:46 ` Junio C Hamano
2022-08-27 12:58 ` Jeff King
2022-08-29 5:56 ` Junio C Hamano
2022-08-29 10:29 ` Ævar Arnfjörð Bjarmason
2022-08-31 15:12 ` Jeff King
2022-08-31 8:44 ` SZEDER Gábor
2022-08-31 12:13 ` Ævar Arnfjörð Bjarmason
2022-08-31 15:24 ` Jeff King
2022-08-31 19:19 ` Junio C Hamano
2022-08-31 18:05 ` SZEDER Gábor
2022-08-31 19:29 ` Ævar Arnfjörð Bjarmason
2022-08-25 14:57 ` Ævar Arnfjörð Bjarmason [this message]
2022-08-25 16:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220825.865yig4bd7.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).