From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Xavier Morel <xavier.morel@masklinn.net>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] fsck: actually detect bad file modes in trees
Date: Wed, 10 Aug 2022 17:46:10 -0400 [thread overview]
Message-ID: <YvQnIuVzMrOaM589@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq4jyjkcij.fsf@gitster.g>
On Wed, Aug 10, 2022 at 02:35:32PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > We use the normal tree_desc code to iterate over trees in fsck, meaning
> > we only see the canonicalized modes it returns. And hence we'd never see
> > anything unexpected, since it will coerce literally any garbage into one
> > of our normal and accepted modes.
>
> Wow. I did know canon_mode() deliberately discarding the extra
> permission bits on trees and blobs, but it was that bad to mark
> whatever it does not understand as a gitlink. That is simply
> horrible.
Yeah, I noticed that, as well. It might actually be reasonable to put a
die() at the end of that canon_mode() function. It's rather unfriendly,
but then, treating nonsense as a gitlink is likely to just result in the
caller ending up aborting anyway.
Outside the scope of my patch, though. :)
-Peff
next prev parent reply other threads:[~2022-08-10 21:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 13:43 fsck: BAD_FILEMODE diagnostic broken / never triggers Xavier Morel
2022-08-09 22:48 ` Jeff King
2022-08-09 23:28 ` Jeff King
2022-08-10 15:01 ` Xavier Morel
2022-08-10 20:04 ` Jeff King
2022-08-10 20:59 ` [PATCH 0/3] actually detect bad file modes in fsck Jeff King
2022-08-10 21:01 ` [PATCH 1/3] tree-walk: add a mechanism for getting non-canonicalized modes Jeff King
2022-08-10 21:02 ` [PATCH 2/3] fsck: actually detect bad file modes in trees Jeff King
2022-08-10 21:35 ` Junio C Hamano
2022-08-10 21:46 ` Jeff King [this message]
2022-08-10 21:54 ` Junio C Hamano
2022-08-10 21:04 ` [PATCH 3/3] fsck: downgrade tree badFilemode to "info" Jeff King
2022-08-10 22:08 ` Junio C Hamano
2022-08-11 8:33 ` Jeff King
2022-08-11 16:24 ` Junio C Hamano
2022-08-11 9:39 ` [PATCH 0/3] actually detect bad file modes in fsck Ævar Arnfjörð Bjarmason
2022-08-14 7:03 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvQnIuVzMrOaM589@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=xavier.morel@masklinn.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).