From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 72D2F1F54E for ; Wed, 10 Aug 2022 21:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231602AbiHJVqQ (ORCPT ); Wed, 10 Aug 2022 17:46:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231508AbiHJVqN (ORCPT ); Wed, 10 Aug 2022 17:46:13 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02AAF5005E for ; Wed, 10 Aug 2022 14:46:11 -0700 (PDT) Received: (qmail 7026 invoked by uid 109); 10 Aug 2022 21:46:11 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 10 Aug 2022 21:46:11 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 16097 invoked by uid 111); 10 Aug 2022 21:46:11 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 10 Aug 2022 17:46:11 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 10 Aug 2022 17:46:10 -0400 From: Jeff King To: Junio C Hamano Cc: Xavier Morel , git@vger.kernel.org Subject: Re: [PATCH 2/3] fsck: actually detect bad file modes in trees Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Aug 10, 2022 at 02:35:32PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > We use the normal tree_desc code to iterate over trees in fsck, meaning > > we only see the canonicalized modes it returns. And hence we'd never see > > anything unexpected, since it will coerce literally any garbage into one > > of our normal and accepted modes. > > Wow. I did know canon_mode() deliberately discarding the extra > permission bits on trees and blobs, but it was that bad to mark > whatever it does not understand as a gitlink. That is simply > horrible. Yeah, I noticed that, as well. It might actually be reasonable to put a die() at the end of that canon_mode() function. It's rather unfriendly, but then, treating nonsense as a gitlink is likely to just result in the caller ending up aborting anyway. Outside the scope of my patch, though. :) -Peff