git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Derrick Stolee <derrickstolee@github.com>
Cc: "Abhradeep Chakraborty" <chakrabortyabhradeep79@gmail.com>,
	git <git@vger.kernel.org>, "Junio C Hamano" <gitster@pobox.com>,
	"Taylor Blau" <me@ttaylorr.com>,
	"Kaartic Sivaraam" <kaartic.sivaraam@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Jakub Narębski" <jnareb@gmail.com>
Subject: Re: Can I use CRoaring library in Git?
Date: Mon, 18 Jul 2022 21:48:54 +0000	[thread overview]
Message-ID: <YtXVRgYJsN4ownRl@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <9c909270-cbd5-0356-0418-4b2d3e105c93@github.com>

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

On 2022-07-18 at 12:18:14, Derrick Stolee wrote:
> On 7/18/22 7:48 AM, Abhradeep Chakraborty wrote:
> > I just got to know that CRoaring doesn't support Big Endian systems (till now) -
> > 
> > https://groups.google.com/g/roaring-bitmaps/c/CzLmIRnYlps
> > 
> > What do you think about this?
> 
> Git cares enough about compatibility that that might be a
> deal-breaker for taking the code as-is. If we _did_ take it
> as-is, then we would need to not make it available on such
> machines using compiler macros.

Debian definitely targets big-endian systems and the Debian maintainer
will likely not be amused if functionality differs across systems.  That
tends to add a bunch of hassle to the maintenance process and ends up
resulting in bug reports and a poor user experience.

I certainly strongly feel that our code should be fully functional
across all architectures that make POSIX-compatible assumptions,
including big-endian systems.  I've ported code to make it work on
UltraSPARC before (for endianness and alignment) and it isn't usually
too hard to fix things, so we likely be able to ship code that's
portable.

In addition, we also need to consider that other systems like NetBSD,
Dragonfly BSD, and OpenBSD are not supported upstream, and thus we will
likely need to patch the code anyway.
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  parent reply	other threads:[~2022-07-18 21:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-16 13:50 Can I use CRoaring library in Git? Abhradeep Chakraborty
2022-07-16 14:16 ` Ævar Arnfjörð Bjarmason
2022-07-16 16:26   ` Abhradeep Chakraborty
2022-07-17 12:25     ` Kaartic Sivaraam
2022-07-17 22:00       ` Junio C Hamano
2022-07-17 22:25         ` Taylor Blau
2022-07-18  8:57           ` Abhradeep Chakraborty
2022-07-25 22:11             ` Taylor Blau
2022-07-17 14:43 ` Derrick Stolee
2022-07-18 11:13 ` Jakub Narębski
2022-07-18 11:38   ` Abhradeep Chakraborty
2022-07-18 13:38     ` Ævar Arnfjörð Bjarmason
2022-07-18 11:48 ` Abhradeep Chakraborty
2022-07-18 12:18   ` Derrick Stolee
2022-07-18 13:15     ` Abhradeep Chakraborty
2022-07-18 21:48     ` brian m. carlson [this message]
2022-07-25 22:14     ` Taylor Blau
2022-07-25 22:35       ` rsbecker
2022-07-25 23:37         ` Taylor Blau
2022-07-21  4:07 ` Abhradeep Chakraborty
2022-07-21  6:12   ` Junio C Hamano
2022-07-21 12:14     ` Derrick Stolee
2022-07-21 13:51       ` Ævar Arnfjörð Bjarmason
2022-07-21 14:57         ` Abhradeep Chakraborty
2022-07-22 11:07           ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtXVRgYJsN4ownRl@tapette.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=avarab@gmail.com \
    --cc=chakrabortyabhradeep79@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).