git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: "Abhradeep Chakraborty" <chakrabortyabhradeep79@gmail.com>,
	git <git@vger.kernel.org>, "Junio C Hamano" <gitster@pobox.com>,
	"Kaartic Sivaraam" <kaartic.sivaraam@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Jakub Narębski" <jnareb@gmail.com>
Subject: Re: Can I use CRoaring library in Git?
Date: Mon, 25 Jul 2022 18:14:37 -0400	[thread overview]
Message-ID: <Yt8VzTLmVOKCALxr@nand.local> (raw)
In-Reply-To: <9c909270-cbd5-0356-0418-4b2d3e105c93@github.com>

On Mon, Jul 18, 2022 at 08:18:14AM -0400, Derrick Stolee wrote:
> On 7/18/22 7:48 AM, Abhradeep Chakraborty wrote:
> > I just got to know that CRoaring doesn't support Big Endian systems (till now) -
> >
> > https://groups.google.com/g/roaring-bitmaps/c/CzLmIRnYlps
> >
> > What do you think about this?
>
> Git cares enough about compatibility that that might be a
> deal-breaker for taking the code as-is. If we _did_ take it
> as-is, then we would need to not make it available on such
> machines using compiler macros.

I definitely agree here. If I'm understanding CRoaring's implementation
correctly, a bitmap written on a machine that uses big endian would be
unreadable on a little endian machine and vice-versa.

That's definitely *not* the case with the existing EWAH bitmaps, which
are readable on machines using either endianness, since we always write
numbers in network byte order, independent of machine endinaness.

(I suspect you know all of this already, but just stating here
explicitly for the benefit of the list).

Thanks,
Taylor

  parent reply	other threads:[~2022-07-25 22:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-16 13:50 Can I use CRoaring library in Git? Abhradeep Chakraborty
2022-07-16 14:16 ` Ævar Arnfjörð Bjarmason
2022-07-16 16:26   ` Abhradeep Chakraborty
2022-07-17 12:25     ` Kaartic Sivaraam
2022-07-17 22:00       ` Junio C Hamano
2022-07-17 22:25         ` Taylor Blau
2022-07-18  8:57           ` Abhradeep Chakraborty
2022-07-25 22:11             ` Taylor Blau
2022-07-17 14:43 ` Derrick Stolee
2022-07-18 11:13 ` Jakub Narębski
2022-07-18 11:38   ` Abhradeep Chakraborty
2022-07-18 13:38     ` Ævar Arnfjörð Bjarmason
2022-07-18 11:48 ` Abhradeep Chakraborty
2022-07-18 12:18   ` Derrick Stolee
2022-07-18 13:15     ` Abhradeep Chakraborty
2022-07-18 21:48     ` brian m. carlson
2022-07-25 22:14     ` Taylor Blau [this message]
2022-07-25 22:35       ` rsbecker
2022-07-25 23:37         ` Taylor Blau
2022-07-21  4:07 ` Abhradeep Chakraborty
2022-07-21  6:12   ` Junio C Hamano
2022-07-21 12:14     ` Derrick Stolee
2022-07-21 13:51       ` Ævar Arnfjörð Bjarmason
2022-07-21 14:57         ` Abhradeep Chakraborty
2022-07-22 11:07           ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yt8VzTLmVOKCALxr@nand.local \
    --to=me@ttaylorr.com \
    --cc=avarab@gmail.com \
    --cc=chakrabortyabhradeep79@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=kaartic.sivaraam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).