From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Kevin Willford <Kevin.Willford@microsoft.com>
Subject: Re: [PATCH] p3400: stop using tac(1)
Date: Mon, 4 Oct 2021 04:31:35 -0400 [thread overview]
Message-ID: <YVq752xjzYz+LTq6@coredump.intra.peff.net> (raw)
In-Reply-To: <85831cc2-307f-1be8-9bb3-c44028ad07fa@web.de>
On Sat, Oct 02, 2021 at 07:44:14PM +0200, René Scharfe wrote:
> b3dfeebb92 (rebase: avoid computing unnecessary patch IDs, 2016-07-29)
> added a perf test that calls tac(1) from GNU core utilities. Support
> systems without it by reversing the generated list using sort -nr
> instead. sort(1) with options -n and -r is already used in other tests.
Cute fix. With regular seq(1), this whole thing can become:
seq 1000 -1 1
without the extra process, but our test_seq doesn't understand non-1
increments (nor comparisons besides -le). It wouldn't be that hard to
teach it, but given that this is the first time we've wanted it, it may
not be worth the effort.
-Peff
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 6348e8d733..76c8c0f2f6 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -1149,15 +1149,22 @@ test_cmp_fspath () {
test_seq () {
case $# in
- 1) set 1 "$@" ;;
- 2) ;;
- *) BUG "not 1 or 2 parameters to test_seq" ;;
+ 1) set 1 1 "$1" ;;
+ 2) set "$1" 1 "$2" ;;
+ 3) ;;
+ *) BUG "not 1, 2, or 3 parameters to test_seq" ;;
esac
+ if test "$1" -lt "$3"
+ then
+ test_seq_cmp__=-le
+ else
+ test_seq_cmp__=-ge
+ fi
test_seq_counter__=$1
- while test "$test_seq_counter__" -le "$2"
+ while test "$test_seq_counter__" $test_seq_cmp__ "$3"
do
echo "$test_seq_counter__"
- test_seq_counter__=$(( $test_seq_counter__ + 1 ))
+ test_seq_counter__=$(( $test_seq_counter__ + $2 ))
done
}
next prev parent reply other threads:[~2021-10-04 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 17:44 [PATCH] p3400: stop using tac(1) René Scharfe
2021-10-04 8:31 ` Jeff King [this message]
2021-10-05 18:45 ` René Scharfe
2021-10-05 19:38 ` Jeff King
2021-10-05 19:54 ` René Scharfe
2021-10-07 20:42 ` René Scharfe
2021-10-07 23:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVq752xjzYz+LTq6@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Kevin.Willford@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).