From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: "Marvin Häuser" <mhaeuser@posteo.de>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [BUG] send-email propagates "In-Reply-To"
Date: Tue, 24 Aug 2021 00:48:52 -0700 [thread overview]
Message-ID: <YSSkZIFaiDyELMJP@carlos-mbp.lan> (raw)
In-Reply-To: <2412df60-f8ee-ab0f-08b2-20a0b6b641fa@posteo.de>
On Mon, Aug 23, 2021 at 09:47:28PM +0000, Marvin Häuser wrote:
> On 23/08/2021 20:27, Jeff King wrote:
> > But either that should go into its own patch, or the commit message
> > should be modified to explain that it is covering not just
> > in-reply-to/references, but we think this fixes all similar variables.
>
> Fixed, opted for latter [1].
Left a comment in github; dropping the "Subject" move would be also
needed to fully do that (the fix doesn't need it)
> > - note the weird behavior I found with --in-reply-to; this is
> > something we might want to address at the same time
>
> I think this case must error? The definition of the "--in-reply-to" does not
> declare it as a default, so it must be enforced (and it is), but it's also
> very unintuitive the file value is discarded. Who would decide the behaviour
> spec?
AFAIK, this is what the cryptic warning in the documentation[1] talks about.
the "argument" being that most of the times that header is incorrect
(because it was incorrectly set by format-patch) or it is meant to be wiped out
to keep this patch together with the rest in the reroll.
the warning was added with f693b7e9a5 (Improve doc for format-patch threading
options., 2009-07-22), so throwing an error now might not be wise, but maybe
a documentation update.
Carlo
[1] https://git-scm.com/docs/git-send-email#Documentation/git-send-email.txt---no-thread
-------- >8 ----------
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 3db4eab4ba..76687d0574 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -385,10 +385,10 @@ default to --thread.
It is up to the user to ensure that no In-Reply-To header already
exists when 'git send-email' is asked to add it (especially note that
'git format-patch' can be configured to do the threading itself).
-Failure to do so may not produce the expected result in the
+Failure to do so will result in that header being reset, accordingly
+to the options used and may not produce the expected result in the
recipient's MUA.
-
Administering
~~~~~~~~~~~~~
next prev parent reply other threads:[~2021-08-24 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 9:24 [BUG] send-email propagates "In-Reply-To" Marvin Häuser
2021-08-22 12:11 ` Bagas Sanjaya
2021-08-23 16:35 ` Jeff King
2021-08-23 17:44 ` Marvin Häuser
2021-08-23 18:27 ` Jeff King
2021-08-23 21:47 ` Marvin Häuser
2021-08-24 7:48 ` Carlo Marcelo Arenas Belón [this message]
2021-08-25 0:15 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSSkZIFaiDyELMJP@carlos-mbp.lan \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=mhaeuser@posteo.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).