From: "Marvin Häuser" <mhaeuser@posteo.de>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [BUG] send-email propagates "In-Reply-To"
Date: Mon, 23 Aug 2021 21:47:28 +0000 [thread overview]
Message-ID: <2412df60-f8ee-ab0f-08b2-20a0b6b641fa@posteo.de> (raw)
In-Reply-To: <YSPomC95hxZZTHRe@coredump.intra.peff.net>
On 23/08/2021 20:27, Jeff King wrote:
> But either that should go into its own patch, or the commit message
> should be modified to explain that it is covering not just
> in-reply-to/references, but we think this fixes all similar variables.
Fixed, opted for latter [1].
> You'd want something like the patch below (and possibly something
> similar for the $subject handling).
Thanks a lot! my last question for the patch would now be, how do I use
your snippet? Do I add you to S-o-b of the single patch, do I split the
patches with the second S-o-b being yours, or do I submit only the first
and you will submit the second?
> Both of the new tests fail without your patch and pass with it, but:
>
> - note the weird behavior I found with --in-reply-to; this is
> something we might want to address at the same time
I think this case must error? The definition of the "--in-reply-to" does
not declare it as a default, so it must be enforced (and it is), but
it's also very unintuitive the file value is discarded. Who would decide
the behaviour spec?
> - applying your patch fails the earlier t9001.52 ("In-Reply-To without
> --chain-reply-to"). I didn't dig into what's going on there.
Fixed [1].
Best regards,
Marvin
[1]
https://github.com/mhaeuser/git/commit/5f2ff790cc0d0d779bc252b08f9c9c632c4ff01c
next prev parent reply other threads:[~2021-08-23 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 9:24 [BUG] send-email propagates "In-Reply-To" Marvin Häuser
2021-08-22 12:11 ` Bagas Sanjaya
2021-08-23 16:35 ` Jeff King
2021-08-23 17:44 ` Marvin Häuser
2021-08-23 18:27 ` Jeff King
2021-08-23 21:47 ` Marvin Häuser [this message]
2021-08-24 7:48 ` Carlo Marcelo Arenas Belón
2021-08-25 0:15 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2412df60-f8ee-ab0f-08b2-20a0b6b641fa@posteo.de \
--to=mhaeuser@posteo.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).