From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2] perf: fix when running with TEST_OUTPUT_DIRECTORY
Date: Mon, 19 Jul 2021 06:53:30 -0400 [thread overview]
Message-ID: <YPVZqn0Lm6m6GC2Z@coredump.intra.peff.net> (raw)
In-Reply-To: <YPVZZl1FI0D8kK6C@ncase>
On Mon, Jul 19, 2021 at 12:52:22PM +0200, Patrick Steinhardt wrote:
> On Mon, Jul 19, 2021 at 04:25:29AM -0400, Jeff King wrote:
> > On Fri, Jun 18, 2021 at 03:56:08PM +0200, Patrick Steinhardt wrote:
> [snip]
> > > diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
> > > index 601d9f67dd..f5ed092ee5 100644
> > > --- a/t/perf/perf-lib.sh
> > > +++ b/t/perf/perf-lib.sh
> > > @@ -45,7 +45,7 @@ export TEST_DIRECTORY TRASH_DIRECTORY GIT_BUILD_DIR GIT_TEST_CMP
> > > MODERN_GIT=$GIT_BUILD_DIR/bin-wrappers/git
> > > export MODERN_GIT
> > >
> > > -perf_results_dir=$TEST_OUTPUT_DIRECTORY/test-results
> > > +perf_results_dir=$TEST_RESULTS_DIR
> >
> > This line puzzled me a bit. Isn't $TEST_RESULTS_DIR already defined to
> > be $TEST_OUTPUT_DIRECTORY/test-results? If the change here is just for
> > clarity / readability that's OK by me. I just want to make sure I'm not
> > missing something.
>
> Yes it is, and IIRC the change was just for clarity as you assume. The
> logic to derive the results directory was essentially duplicated across
> perf-lib.sh and test-lib.sh without much of a reason, given that we
> always set TEST_RESULTS_DIR in test-lib.sh.
OK, thanks. Then your patch looks great to me. :)
-Peff
prev parent reply other threads:[~2021-07-19 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:12 [PATCH] perf: fix when running with TEST_OUTPUT_DIRECTORY Patrick Steinhardt
2021-06-16 11:33 ` Ævar Arnfjörð Bjarmason
2021-06-16 12:13 ` Patrick Steinhardt
2021-06-18 13:56 ` [PATCH v2] " Patrick Steinhardt
2021-06-29 1:12 ` Junio C Hamano
2021-07-19 8:25 ` Jeff King
2021-07-19 10:52 ` Patrick Steinhardt
2021-07-19 10:53 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPVZqn0Lm6m6GC2Z@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).