From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 1BB081F5AE for ; Mon, 19 Jul 2021 10:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236510AbhGSKMx (ORCPT ); Mon, 19 Jul 2021 06:12:53 -0400 Received: from cloud.peff.net ([104.130.231.41]:53490 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236487AbhGSKMw (ORCPT ); Mon, 19 Jul 2021 06:12:52 -0400 Received: (qmail 30968 invoked by uid 109); 19 Jul 2021 10:53:30 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 19 Jul 2021 10:53:30 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12192 invoked by uid 111); 19 Jul 2021 10:53:31 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 19 Jul 2021 06:53:31 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 19 Jul 2021 06:53:30 -0400 From: Jeff King To: Patrick Steinhardt Cc: Junio C Hamano , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH v2] perf: fix when running with TEST_OUTPUT_DIRECTORY Message-ID: References: <005cc9a695f7f9b17190293821369763e9bae662.1623834515.git.ps@pks.im> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jul 19, 2021 at 12:52:22PM +0200, Patrick Steinhardt wrote: > On Mon, Jul 19, 2021 at 04:25:29AM -0400, Jeff King wrote: > > On Fri, Jun 18, 2021 at 03:56:08PM +0200, Patrick Steinhardt wrote: > [snip] > > > diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh > > > index 601d9f67dd..f5ed092ee5 100644 > > > --- a/t/perf/perf-lib.sh > > > +++ b/t/perf/perf-lib.sh > > > @@ -45,7 +45,7 @@ export TEST_DIRECTORY TRASH_DIRECTORY GIT_BUILD_DIR GIT_TEST_CMP > > > MODERN_GIT=$GIT_BUILD_DIR/bin-wrappers/git > > > export MODERN_GIT > > > > > > -perf_results_dir=$TEST_OUTPUT_DIRECTORY/test-results > > > +perf_results_dir=$TEST_RESULTS_DIR > > > > This line puzzled me a bit. Isn't $TEST_RESULTS_DIR already defined to > > be $TEST_OUTPUT_DIRECTORY/test-results? If the change here is just for > > clarity / readability that's OK by me. I just want to make sure I'm not > > missing something. > > Yes it is, and IIRC the change was just for clarity as you assume. The > logic to derive the results directory was essentially duplicated across > perf-lib.sh and test-lib.sh without much of a reason, given that we > always set TEST_RESULTS_DIR in test-lib.sh. OK, thanks. Then your patch looks great to me. :) -Peff