From: Jeff King <email@example.com> To: "brian m. carlson" <firstname.lastname@example.org> Cc: Felipe Contreras <email@example.com>, Bagas Sanjaya <firstname.lastname@example.org>, Git Users <email@example.com> Subject: Re: [RFC suggestion] Generate manpage directly with Asciidoctor Date: Fri, 7 May 2021 23:23:48 -0400 [thread overview] Message-ID: <YJYERMX0OZI6DEWR@coredump.intra.peff.net> (raw) In-Reply-To: <YJYBOrm2cQkkVteb@coredump.intra.peff.net> On Fri, May 07, 2021 at 11:10:50PM -0400, Jeff King wrote: > On Fri, May 07, 2021 at 11:57:32PM +0000, brian m. carlson wrote: > > > It's not quite that simple. It requires changes to > > asciidoctor-extensions.rb and we also need to consider > > NO_MAN_BOLD_LITERAL and GNU_ROFF. The latter especially is likely to be > > inconvenient, since according to the Makefile, it's impossible to write > > man output that works across troff versions. > > > > We will also want to preserve the ability to use xmlto because we > > currently have doc-diff which helps us find divergences in the behavior > > of AsciiDoc and Asciidoctor, many of which affect all formats, and that > > will be completely useless if we use two different rendering toolchains. > > Speaking of doc-diff: with that patch applied, try "./doc-diff > --asciidoctor HEAD^ HEAD", which shows quite a few of the complications > (another one seems to be that all of the linkgit macros are broken). Hmph. Actually, this seems to give inconsistent results. There definitely is a problem. Try: cd Documentation make USE_ASCIIDOCTOR=1 git.1 man -l git.1 >old git am .../the_patch make USE_ASCIIDOCTOR=1 git.1 man -l git.1 >new diff -u old new which shows it. I think the patch does not specify the dependencies to make correctly (and doc-diff reuses the worktree to avoid work). Doing this: git am .../the_patch ./doc-diff --asciidoctor HEAD HEAD ./doc-diff --asciidoctor HEAD^ HEAD works around it and shows the extent of the problem. (Not really a critique on the patch, which I know was meant to be a quick illustration, but I thought it worth pointing out a doc-diff command which actually works). -Peff
next prev parent reply other threads:[~2021-05-08 3:23 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-07 6:06 Bagas Sanjaya 2021-05-07 12:02 ` Randall S. Becker 2021-05-07 22:55 ` Felipe Contreras 2021-05-07 22:57 ` brian m. carlson 2021-05-08 1:42 ` Randall S. Becker 2021-05-07 12:27 ` Đoàn Trần Công Danh 2021-05-07 12:47 ` Bagas Sanjaya 2021-05-07 23:03 ` Felipe Contreras 2021-05-08 4:27 ` Bagas Sanjaya 2021-05-07 20:25 ` brian m. carlson 2021-05-07 22:19 ` Jeff King 2021-05-08 4:22 ` Bagas Sanjaya 2021-05-09 8:20 ` Martin Ågren 2021-05-09 18:46 ` Felipe Contreras 2021-05-10 18:43 ` Martin Ågren 2021-05-10 22:24 ` Jeff King 2021-05-11 4:27 ` Felipe Contreras 2021-05-11 6:13 ` Jeff King 2021-05-11 8:03 ` Felipe Contreras 2021-05-11 12:44 ` Ævar Arnfjörð Bjarmason 2021-05-11 19:00 ` Felipe Contreras 2021-05-11 19:09 ` Jeff King 2021-05-11 20:22 ` Felipe Contreras 2021-05-11 23:14 ` brian m. carlson 2021-05-12 1:44 ` Felipe Contreras 2021-05-11 18:45 ` Martin Ågren 2021-05-11 19:07 ` Jeff King 2021-05-11 19:11 ` Martin Ågren 2021-05-11 20:14 ` Felipe Contreras 2021-05-11 9:04 ` Jean-Noël Avila 2021-05-11 18:54 ` Martin Ågren 2021-05-07 23:35 ` Felipe Contreras 2021-05-07 23:57 ` brian m. carlson 2021-05-08 3:10 ` Jeff King 2021-05-08 3:23 ` Jeff King [this message] 2021-05-09 0:22 ` brian m. carlson 2021-05-09 8:29 ` Martin Ågren 2021-05-07 22:48 ` Felipe Contreras
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJYERMX0OZI6DEWR@coredump.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [RFC suggestion] Generate manpage directly with Asciidoctor' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).