From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Aleksey Kliger <alklig@microsoft.com>
Subject: Re: [PATCH] wrapper: add workaround for open() returning EINTR
Date: Tue, 23 Feb 2021 23:46:28 -0500 [thread overview]
Message-ID: <YDXaJHnZ5LgCj9NX@coredump.intra.peff.net> (raw)
In-Reply-To: <YDXZY8XFRayiM1If@coredump.intra.peff.net>
On Tue, Feb 23, 2021 at 11:43:16PM -0500, Jeff King wrote:
> The workaround here is enabled all the time, without a Makefile knob,
> since it's a complete noop if open() never returns EINTR. I did push it
> into its own compat/ source file, though, since it has to #undef our
> macro redirection. Putting it in a file with other code risks confusion
> if more code is added after that #undef.
Whoops, sorry, I had a last-minute change of heart here and just stuck
it in wrapper.c with a bit of preprocessor magic to guard it. It felt
weird having compat/open.c, when the rest of compat/ is always
conditional on Makefile knobs. But I'm happy to go the other way if
anybody feels strongly.
-Peff
next prev parent reply other threads:[~2021-02-24 4:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 4:43 [PATCH] wrapper: add workaround for open() returning EINTR Jeff King
2021-02-24 4:46 ` Jeff King [this message]
2021-02-24 5:36 ` Junio C Hamano
2021-02-24 18:20 ` Jeff King
2021-02-26 6:14 ` [PATCH v2] Makefile: add OPEN_RETURNS_EINTR knob Jeff King
2021-02-26 22:17 ` Junio C Hamano
2021-03-01 9:29 ` [PATCH] config.mak.uname: enable OPEN_RETURNS_EINTR for macOS Big Sur Jeff King
2021-03-01 17:17 ` Junio C Hamano
2021-03-01 23:57 ` Junio C Hamano
2021-03-03 13:41 ` Jeff King
2021-03-04 0:47 ` Junio C Hamano
2021-02-24 4:50 ` [PATCH] wrapper: add workaround for open() returning EINTR Taylor Blau
2021-02-24 7:20 ` Johannes Sixt
2021-02-24 18:23 ` Jeff King
2021-02-26 6:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDXaJHnZ5LgCj9NX@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=alklig@microsoft.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).