From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 663501F9FD for ; Wed, 24 Feb 2021 04:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233025AbhBXErK (ORCPT ); Tue, 23 Feb 2021 23:47:10 -0500 Received: from cloud.peff.net ([104.130.231.41]:42666 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232331AbhBXErJ (ORCPT ); Tue, 23 Feb 2021 23:47:09 -0500 Received: (qmail 28959 invoked by uid 109); 24 Feb 2021 04:46:29 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 24 Feb 2021 04:46:29 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 8822 invoked by uid 111); 24 Feb 2021 04:46:28 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 23 Feb 2021 23:46:28 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 23 Feb 2021 23:46:28 -0500 From: Jeff King To: git@vger.kernel.org Cc: Aleksey Kliger Subject: Re: [PATCH] wrapper: add workaround for open() returning EINTR Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Feb 23, 2021 at 11:43:16PM -0500, Jeff King wrote: > The workaround here is enabled all the time, without a Makefile knob, > since it's a complete noop if open() never returns EINTR. I did push it > into its own compat/ source file, though, since it has to #undef our > macro redirection. Putting it in a file with other code risks confusion > if more code is added after that #undef. Whoops, sorry, I had a last-minute change of heart here and just stuck it in wrapper.c with a bit of preprocessor magic to guard it. It felt weird having compat/open.c, when the rest of compat/ is always conditional on Makefile knobs. But I'm happy to go the other way if anybody feels strongly. -Peff