From: Jeff King <peff@peff.net>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Christian Couder <chriscool@tuxfamily.org>,
Jonathan Tan <jonathantanmy@google.com>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v2 0/3] Refactor writing promisor file
Date: Thu, 14 Jan 2021 15:11:44 -0500 [thread overview]
Message-ID: <YAClgD7HNglz2LtV@coredump.intra.peff.net> (raw)
In-Reply-To: <20210114155016.3005932-1-chriscool@tuxfamily.org>
On Thu, Jan 14, 2021 at 04:50:13PM +0100, Christian Couder wrote:
> This is a small patch series to refactor the code that actually writes
> a promisor file (<pack-name>.promisor) into a write_promisor_file()
> function, and then to improve it a bit.
>
> Compared to version 1 of this patch series, the only difference is
> that patch 3/3 has been added to die() in case of error, instead of
> ignoring it, when actually writing the content of the file or closing
> it. Thanks to Peff and Taylor for their suggestions.
These look great to me. Thanks for adding the extra error handling.
-Peff
prev parent reply other threads:[~2021-01-14 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 15:50 [PATCH v2 0/3] Refactor writing promisor file Christian Couder
2021-01-14 15:50 ` [PATCH v2 1/3] fetch-pack: rename helper to create_promisor_file() Christian Couder
2021-01-14 15:50 ` [PATCH v2 2/3] fetch-pack: refactor writing promisor file Christian Couder
2021-01-14 15:50 ` [PATCH v2 3/3] pack-write: die on error in write_promisor_file() Christian Couder
2021-01-14 17:23 ` [PATCH v2 0/3] Refactor writing promisor file Taylor Blau
2021-01-14 20:11 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAClgD7HNglz2LtV@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).