From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 0001E1F934 for ; Thu, 14 Jan 2021 20:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729661AbhANUMZ (ORCPT ); Thu, 14 Jan 2021 15:12:25 -0500 Received: from cloud.peff.net ([104.130.231.41]:56436 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727181AbhANUMZ (ORCPT ); Thu, 14 Jan 2021 15:12:25 -0500 Received: (qmail 17786 invoked by uid 109); 14 Jan 2021 20:11:45 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 14 Jan 2021 20:11:45 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 17727 invoked by uid 111); 14 Jan 2021 20:11:45 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 14 Jan 2021 15:11:45 -0500 Authentication-Results: peff.net; auth=none Date: Thu, 14 Jan 2021 15:11:44 -0500 From: Jeff King To: Christian Couder Cc: git@vger.kernel.org, Junio C Hamano , Christian Couder , Jonathan Tan , Taylor Blau Subject: Re: [PATCH v2 0/3] Refactor writing promisor file Message-ID: References: <20210114155016.3005932-1-chriscool@tuxfamily.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210114155016.3005932-1-chriscool@tuxfamily.org> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jan 14, 2021 at 04:50:13PM +0100, Christian Couder wrote: > This is a small patch series to refactor the code that actually writes > a promisor file (.promisor) into a write_promisor_file() > function, and then to improve it a bit. > > Compared to version 1 of this patch series, the only difference is > that patch 3/3 has been added to die() in case of error, instead of > ignoring it, when actually writing the content of the file or closing > it. Thanks to Peff and Taylor for their suggestions. These look great to me. Thanks for adding the extra error handling. -Peff