From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] bisect; remove unused "git-bisect.sh" and ".gitignore" entry
Date: Tue, 15 Nov 2022 14:39:53 -0500 [thread overview]
Message-ID: <Y3PrCX7W7gL1Z0CI@nand.local> (raw)
In-Reply-To: <Y3PHOpIqMC9ZT4pg@coredump.intra.peff.net>
On Tue, Nov 15, 2022 at 12:07:06PM -0500, Jeff King wrote:
> On Tue, Nov 15, 2022 at 10:32:42AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> > Since fc304fb52f9 (Merge branch 'dd/git-bisect-builtin' into next,
> > 2022-11-14) we've used builtin/bisect.c instead of git-bisect.sh to
> > implement the "bisect" command. Let's remove the unused leftover
> > script, and the ".gitignore" entry for the "git-bisect--helper", which
> > also hasn't been built since fc304fb52f9.
>
> A small nit, but it's probably not a good idea to refer to merge commits
> from 'next'. They may be meaningful now, but they aren't part of the
> long-term history, and will get gc'd eventually when Junio rewinds next
> after a release. Which will leave this reference useless for people
> looking at "git log" a year from now.
>
> A better reference is probably 73fce29427 (Turn `git bisect` into a full
> built-in, 2022-11-10), which will remain stable as it gets merged
> eventually into master.
Thanks, I updated the reference to point at 73fce29427 while queueing.
As an aside, I am a little disappointed by the quality of what has
recently been hitting 'next'. There was no chance for me to find the
issues with t7610 without a Windows machine, but this should have been
caught during testing.
Thanks,
Taylor
next prev parent reply other threads:[~2022-11-15 19:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 9:32 [PATCH] bisect; remove unused "git-bisect.sh" and ".gitignore" entry Ævar Arnfjörð Bjarmason
2022-11-15 17:07 ` Jeff King
2022-11-15 19:39 ` Taylor Blau [this message]
2022-11-16 14:52 ` Đoàn Trần Công Danh
2022-11-16 20:14 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3PrCX7W7gL1Z0CI@nand.local \
--to=me@ttaylorr.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).