mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: "Ævar Arnfjörð Bjarmason" <>
Cc:, "Taylor Blau" <>,
	"Đoàn Trần Công Danh" <>,
	"Johannes Schindelin" <>
Subject: Re: [PATCH] bisect; remove unused "" and ".gitignore" entry
Date: Tue, 15 Nov 2022 12:07:06 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Nov 15, 2022 at 10:32:42AM +0100, Ævar Arnfjörð Bjarmason wrote:

> Since fc304fb52f9 (Merge branch 'dd/git-bisect-builtin' into next,
> 2022-11-14) we've used builtin/bisect.c instead of to
> implement the "bisect" command. Let's remove the unused leftover
> script, and the ".gitignore" entry for the "git-bisect--helper", which
> also hasn't been built since fc304fb52f9.

A small nit, but it's probably not a good idea to refer to merge commits
from 'next'. They may be meaningful now, but they aren't part of the
long-term history, and will get gc'd eventually when Junio rewinds next
after a release. Which will leave this reference useless for people
looking at "git log" a year from now.

A better reference is probably 73fce29427 (Turn `git bisect` into a full
built-in, 2022-11-10), which will remain stable as it gets merged
eventually into master.

>  .gitignore    |  1 -
> | 63 ---------------------------------------------------

The patch itself looks like an obviously correct thing to do.


  reply	other threads:[~2022-11-15 17:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15  9:32 [PATCH] bisect; remove unused "" and ".gitignore" entry Ævar Arnfjörð Bjarmason
2022-11-15 17:07 ` Jeff King [this message]
2022-11-15 19:39   ` Taylor Blau
2022-11-16 14:52 ` Đoàn Trần Công Danh
2022-11-16 20:14   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).