From: Jeff King <peff@peff.net>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Martin Englund <martin@englund.nu>, git@vger.kernel.org
Subject: Re: Git Bug Report: out of memory using git tag
Date: Thu, 3 Nov 2022 00:32:57 -0400 [thread overview]
Message-ID: <Y2NEeWwnfHnIbNl8@coredump.intra.peff.net> (raw)
In-Reply-To: <49e1eec2-0567-f75e-7d0d-0f2d00ac472c@gmail.com>
On Wed, Nov 02, 2022 at 08:13:27AM -0400, Philippe Blain wrote:
> > [1/2]: ref-filter: fix parsing of signatures without blank lines
> > [2/2]: ref-filter: fix parsing of signatures with CRLF and no body
> [...]
> One thing I think that is not mentioned in your commit messages is that 1/2
> would also apply to a CRLF-using tag with no blank lines, i.e.
>
> this is the subject^M
> -----BEGIN PGP SIGNATURE-----^M
> ...some stuff...^M
> -----END PGP SIGNATURE-----^M
>
> Parsing this tag correctly is fixed by 1/2, right?
Right. Because there's no blank line to find, neither the "\n\n" nor the
"\r\n\r\n" strstr matches, so it is essentially the same case. The fact
that the other non-blank lines are CRLF doesn't matter for this part of
the code. :)
> Anyway thanks again for the fixes,
No problem!
-Peff
next prev parent reply other threads:[~2022-11-03 4:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 22:29 Git Bug Report: out of memory using git tag Martin Englund
2022-11-01 12:22 ` Jeff King
2022-11-02 0:41 ` Philippe Blain
2022-11-02 7:39 ` Jeff King
2022-11-02 7:42 ` [PATCH 1/2] ref-filter: fix parsing of signatures without blank lines Jeff King
2022-11-02 7:44 ` [PATCH 2/2] ref-filter: fix parsing of signatures with CRLF and no body Jeff King
2022-11-02 8:14 ` Git Bug Report: out of memory using git tag Elijah Newren
2022-11-02 9:13 ` gigantic commit messages, was " Jeff King
2022-11-02 14:26 ` Ævar Arnfjörð Bjarmason
2022-11-02 15:43 ` Elijah Newren
2022-11-02 8:24 ` Eric Sunshine
2022-11-02 12:13 ` Philippe Blain
2022-11-03 4:32 ` Jeff King [this message]
2022-11-03 0:42 ` Taylor Blau
2022-11-02 0:42 ` Philippe Blain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2NEeWwnfHnIbNl8@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
--cc=martin@englund.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).