From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Philippe Blain <levraiphilippeblain@gmail.com>,
Martin Englund <martin@englund.nu>,
git@vger.kernel.org
Subject: Re: Git Bug Report: out of memory using git tag
Date: Wed, 2 Nov 2022 20:42:09 -0400 [thread overview]
Message-ID: <Y2MOYfalWOB9YlP2@nand.local> (raw)
In-Reply-To: <Y2IeqOT5Ao1Qa0Zl@coredump.intra.peff.net>
On Wed, Nov 02, 2022 at 03:39:20AM -0400, Jeff King wrote:
> After sleeping on it, I think I fully understand what's going on. There
> are actually _two_ bugs, but they are closely related. ;)
>
> Here are patches which fix them both. I may be setting a new record for
> the ratio of commit message lines to changed code. But it took me a
> while to figure out what was going on, so I wanted to explain it fully.
>
> [1/2]: ref-filter: fix parsing of signatures without blank lines
> [2/2]: ref-filter: fix parsing of signatures with CRLF and no body
Indeed. I agree with others below in the thread that this is very well
explained, and the fix(es) both look sensible to me.
Will queue, thanks.
Thanks,
Taylor
next prev parent reply other threads:[~2022-11-03 0:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 22:29 Git Bug Report: out of memory using git tag Martin Englund
2022-11-01 12:22 ` Jeff King
2022-11-02 0:41 ` Philippe Blain
2022-11-02 7:39 ` Jeff King
2022-11-02 7:42 ` [PATCH 1/2] ref-filter: fix parsing of signatures without blank lines Jeff King
2022-11-02 7:44 ` [PATCH 2/2] ref-filter: fix parsing of signatures with CRLF and no body Jeff King
2022-11-02 8:14 ` Git Bug Report: out of memory using git tag Elijah Newren
2022-11-02 9:13 ` gigantic commit messages, was " Jeff King
2022-11-02 14:26 ` Ævar Arnfjörð Bjarmason
2022-11-02 15:43 ` Elijah Newren
2022-11-02 8:24 ` Eric Sunshine
2022-11-02 12:13 ` Philippe Blain
2022-11-03 4:32 ` Jeff King
2022-11-03 0:42 ` Taylor Blau [this message]
2022-11-02 0:42 ` Philippe Blain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2MOYfalWOB9YlP2@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
--cc=martin@englund.nu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).