From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, vdye@github.com, derrickstolee@github.com
Subject: Re: [PATCH] repack: don't remove .keep packs with `--pack-kept-objects`
Date: Thu, 20 Oct 2022 23:14:12 -0400 [thread overview]
Message-ID: <Y1IOhH2jAwHHrLY+@nand.local> (raw)
In-Reply-To: <Y05NwIfY/906b2Vd@coredump.intra.peff.net>
On Tue, Oct 18, 2022 at 02:54:56AM -0400, Jeff King wrote:
> So the patch looks good to me as-is (and sorry for the verbose review;
> we've just had enough tricky corner cases in this repack code that I
> wanted to make sure I understood all the implications).
Yeah, I agree that this is probably premature optimization, but in
practice it doesn't hurt much. Copying it was definitely intentional,
and I share your general unease about changing it in this patch.
Thanks,
Taylor
prev parent reply other threads:[~2022-10-21 3:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 2:26 [PATCH] repack: don't remove .keep packs with `--pack-kept-objects` Taylor Blau
2022-10-18 6:54 ` Jeff King
2022-10-21 3:14 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1IOhH2jAwHHrLY+@nand.local \
--to=me@ttaylorr.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).