git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Julian Phillips" <julian@quantumfyre.co.uk>,
	"Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>,
	git@vger.kernel.org
Subject: Re: name-rev does not show the shortest path
Date: Mon, 27 Aug 2007 10:57:22 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0708271049000.28586@racer.site> (raw)
In-Reply-To: <20070827092422.GA20340@coredump.intra.peff.net>

Hi,

On Mon, 27 Aug 2007, Jeff King wrote:

> On Sun, Aug 26, 2007 at 05:38:22PM +0200, Johannes Schindelin wrote:
> 
> > The old code _should_ have worked; it is more likely that your 
> > different metric just hides the bug.  The old metric tried to favour 
> > less merge traversals over more traversals, but at the same time, it 
> > favoured smaller numbers over larger ones (but as you found out, only 
> > in the last component).
> 
> Right, the problem is that we have effectively _thrown away_ the
> "smaller numbers over larger ones" information for components other than
> the last.

You're right.  I misremembered name-rev to use a fifo instead of stupid 
recursion.

Will fix.

Ciao,
Dscho

  reply	other threads:[~2007-08-27  9:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-23 10:38 name-rev does not show the shortest path Uwe Kleine-König
2007-08-24 11:55 ` Julian Phillips
2007-08-24 12:52   ` Uwe Kleine-König
2007-08-24 15:21     ` Julian Phillips
2007-08-24 18:33       ` Junio C Hamano
2007-08-25 15:04         ` Johannes Schindelin
2007-08-26  9:23           ` Jeff King
2007-08-26 15:38             ` Johannes Schindelin
2007-08-27  9:24               ` Jeff King
2007-08-27  9:57                 ` Johannes Schindelin [this message]
2007-08-27 11:18                   ` Johannes Schindelin
2007-08-27 11:37 ` [PATCH] name-rev: Fix non-shortest description Johannes Schindelin
2007-08-27 19:27   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0708271049000.28586@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=julian@quantumfyre.co.uk \
    --cc=peff@peff.net \
    --cc=ukleinek@informatik.uni-freiburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).