From: Julian Phillips <julian@quantumfyre.co.uk>
To: git@vger.kernel.org
Subject: Re: [PATCH] refs.c: add a function to sort a ref list, rather then sorting on add
Date: Tue, 17 Apr 2007 22:01:15 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0704172156590.9988@beast.quantumfyre.co.uk> (raw)
In-Reply-To: <20070417014307.12486.28930.julian@quantumfyre.co.uk>
On Tue, 17 Apr 2007, Julian Phillips wrote:
> Rather than sorting the refs list while building it, sort in one go
> after it is built using a merge sort. This has a large performance
> boost with large numbers of refs.
>
> Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
> ---
>
> Having got builtin fetch to the point of generating a correct FETCH_HEAD (for a certain path through the code at least), I revisted the speed issue I brought up a while back with the sorting of refs.
>
> Running fetch (builtin version) on a repo with >9000 refs which is up-to-date, using the old sort-on-add I get (best of 5, warm cache):
>
> real 0m4.351s
> user 0m4.068s
> sys 0m0.219s
>
> With this patch the same fetch gives (worst of 5, warm cache):
>
> real 0m2.196s
> user 0m1.870s
> sys 0m0.212s
>
> Since this is orthogonal to making fetch a builtin, I don't see that it needs to wait ...
In case anyone is curious, doing the same fetch with master
(v1.5.1.1-135-gf948792):
master (best of 5, warm cache):
real 0m33.962s
user 0m23.992s
sys 0m9.986s
master + patch (worst of 5, warm cache):
real 0m20.821s
user 0m10.390s
sys 0m9.799s
--
Julian
---
NANCY!! Why is everything RED?!
prev parent reply other threads:[~2007-04-17 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 1:42 [PATCH] refs.c: add a function to sort a ref list, rather then sorting on add Julian Phillips
2007-04-17 16:03 ` Linus Torvalds
2007-04-17 20:17 ` Julian Phillips
2007-04-17 20:51 ` Linus Torvalds
2007-04-17 22:03 ` Julian Phillips
2007-04-17 22:00 ` Junio C Hamano
2007-04-17 22:43 ` Julian Phillips
2007-04-18 19:36 ` Junio C Hamano
2007-04-18 21:27 ` [PATCH] refs.c: drop duplicate entries in sort_ref_list Julian Phillips
2007-04-19 8:19 ` Johannes Sixt
2007-04-19 8:49 ` Julian Phillips
2007-04-17 21:01 ` Julian Phillips [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704172156590.9988@beast.quantumfyre.co.uk \
--to=julian@quantumfyre.co.uk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).