From: Julian Phillips <julian@quantumfyre.co.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] refs.c: add a function to sort a ref list, rather then sorting on add
Date: Tue, 17 Apr 2007 21:17:14 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0704172114040.8164@beast.quantumfyre.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0704170901170.5473@woody.linux-foundation.org>
On Tue, 17 Apr 2007, Linus Torvalds wrote:
>
>
> On Tue, 17 Apr 2007, Julian Phillips wrote:
>>
>> Rather than sorting the refs list while building it, sort in one go
>> after it is built using a merge sort. This has a large performance
>> boost with large numbers of refs.
>>
>> Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
>
> Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> Looks fine. I think that even your new times are a bit high (over two
> seconds?) but things are clearly better. Have you looked at what takes so
> long now?
It's the tag auto-following code, I'm calling read_ref to see if I already
have that tag - and it appears that doing that a few thousand times takes
a while.
If I comment out that one line (so the code will _always_ think I have
the tags - but I do have them, so ...) I get:
real 0m0.472s
user 0m0.277s
sys 0m0.181s
Looks like read_ref is the wrong thing to be using ...
--
Julian
---
"Life is like a buffet; it's not good but there's plenty of it."
next prev parent reply other threads:[~2007-04-17 20:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 1:42 [PATCH] refs.c: add a function to sort a ref list, rather then sorting on add Julian Phillips
2007-04-17 16:03 ` Linus Torvalds
2007-04-17 20:17 ` Julian Phillips [this message]
2007-04-17 20:51 ` Linus Torvalds
2007-04-17 22:03 ` Julian Phillips
2007-04-17 22:00 ` Junio C Hamano
2007-04-17 22:43 ` Julian Phillips
2007-04-18 19:36 ` Junio C Hamano
2007-04-18 21:27 ` [PATCH] refs.c: drop duplicate entries in sort_ref_list Julian Phillips
2007-04-19 8:19 ` Johannes Sixt
2007-04-19 8:49 ` Julian Phillips
2007-04-17 21:01 ` [PATCH] refs.c: add a function to sort a ref list, rather then sorting on add Julian Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704172114040.8164@beast.quantumfyre.co.uk \
--to=julian@quantumfyre.co.uk \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).